Re: [RFC 3/8] book3s64/hash: Fix phys_addr_t printf format in htab_initialize()
From: Christophe Leroy <hidden>
Date: 2025-08-30 10:50:38
Le 30/08/2025 à 05:51, Ritesh Harjani (IBM) a écrit :
quoted hunk ↗ jump to hunk
We get below errors when we try to enable debug logs in book3s64/hash_utils.c This patch fixes these errors related to phys_addr_t printf format. arch/powerpc/mm/book3s64/hash_utils.c: In function ‘htab_initialize’: arch/powerpc/mm/book3s64/hash_utils.c:1401:21: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 2 has type ‘phys_addr_t’ {aka ‘long long unsigned int’} [-Werror=format=] 1401 | DBG("creating mapping for region: %lx..%lx (prot: %lx)\n", arch/powerpc/mm/book3s64/hash_utils.c:1401:21: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘phys_addr_t’ {aka ‘long long unsigned int’} [-Werror=format=] cc1: all warnings being treated as errors make[6]: *** [../scripts/Makefile.build:287: arch/powerpc/mm/book3s64/hash_utils.o] Error 1 Cc: Madhavan Srinivasan <maddy@linux.ibm.com> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Nicholas Piggin <npiggin@gmail.com> Cc: Christophe Leroy <redacted> Cc: Paul Mackerras <redacted> Cc: "Aneesh Kumar K.V" <aneesh.kumar@kernel.org> Cc: Donet Tom <redacted> Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com> --- arch/powerpc/mm/book3s64/hash_utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/powerpc/mm/book3s64/hash_utils.c b/arch/powerpc/mm/book3s64/hash_utils.c index 1e062056cfb8..495b6da6f5d4 100644 --- a/arch/powerpc/mm/book3s64/hash_utils.c +++ b/arch/powerpc/mm/book3s64/hash_utils.c@@ -1394,7 +1394,7 @@ static void __init htab_initialize(void) size = end - base; base = (unsigned long)__va(base); - DBG("creating mapping for region: %lx..%lx (prot: %lx)\n", + DBG("creating mapping for region: %llx..%llx (prot: %lx)\n",
Use %pa See https://docs.kernel.org/core-api/printk-formats.html#physical-address-types-phys-addr-t
base, size, prot);
if ((base + size) >= H_VMALLOC_START) {
--
2.50.1