Christophe Leroy [off-list ref] writes:

Le 30/08/2025 à 05:51, Ritesh Harjani (IBM) a écrit :

quoted

We dropped preload_new_slb_context() in the previous patch. That means

slb_setup_new_exec() was also checking preload_add() returned value but 
is also gone.

Right. Will add that.

quoted

we don't really need preload_add() return type anymore. So let's make
it's return type to void.

s/it's/its

Sure.

quoted

Cc: Madhavan Srinivasan <maddy@linux.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Christophe Leroy <redacted>
Cc: Paul Mackerras <redacted>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@kernel.org>
Cc: Donet Tom <redacted>
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
---
  arch/powerpc/mm/book3s64/slb.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/mm/book3s64/slb.c b/arch/powerpc/mm/book3s64/slb.c
index 7e053c561a09..780792b9a1e5 100644
--- a/arch/powerpc/mm/book3s64/slb.c
+++ b/arch/powerpc/mm/book3s64/slb.c

@@ -294,7 +294,7 @@ static bool preload_hit(struct thread_info *ti, unsigned long esid)
  	return false;
  }

-static bool preload_add(struct thread_info *ti, unsigned long ea)
+static void preload_add(struct thread_info *ti, unsigned long ea)
  {
  	unsigned char idx;
  	unsigned long esid;

@@ -308,7 +308,7 @@ static bool preload_add(struct thread_info *ti, unsigned long ea)
  	esid = ea >> SID_SHIFT;

  	if (preload_hit(ti, esid))
-		return false;
+		return;

  	idx = (ti->slb_preload_tail + ti->slb_preload_nr) % SLB_PRELOAD_NR;
  	ti->slb_preload_esid[idx] = esid;

@@ -317,7 +317,7 @@ static bool preload_add(struct thread_info *ti, unsigned long ea)
  	else
  		ti->slb_preload_nr++;

-	return true;
+	return;

You don't need a valueless return at the end of a function

Right make sense. I will fix these in the next revision. 
Thanks for the review!

-ritesh