Re: [PATCH v1 17/29] mm/page_isolation: drop __folio_test_movable() check for large folios
From: Lorenzo Stoakes <hidden>
Date: 2025-07-01 11:05:05
Also in:
linux-doc, linux-fsdevel, linux-mm, lkml, virtualization
On Mon, Jun 30, 2025 at 02:59:58PM +0200, David Hildenbrand wrote:
Currently, we only support migration of individual movable_ops pages, so we can not run into that. Reviewed-by: Zi Yan <ziy@nvidia.com> Signed-off-by: David Hildenbrand <redacted>
Seems sensible, so: Reviewed-by: Lorenzo Stoakes <redacted> Maybe worth adding a VM_WARN_ON_ONCE() just in case? Or do you think not worth it?
quoted hunk ↗ jump to hunk
--- mm/page_isolation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/mm/page_isolation.c b/mm/page_isolation.c index b97b965b3ed01..f72b6cd38b958 100644 --- a/mm/page_isolation.c +++ b/mm/page_isolation.c@@ -92,7 +92,7 @@ static struct page *has_unmovable_pages(unsigned long start_pfn, unsigned long e h = size_to_hstate(folio_size(folio)); if (h && !hugepage_migration_supported(h)) return page; - } else if (!folio_test_lru(folio) && !__folio_test_movable(folio)) { + } else if (!folio_test_lru(folio)) { return page; } --2.49.0