Thread (15 messages) 15 messages, 4 authors, 2025-06-04

RE: [PATCH 3/4 v3] ACPI: extlog: Trace CPER PCI Express Error Section

From: "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>
Date: 2025-06-04 14:25:58
Also in: linux-acpi, linux-cxl, linux-edac, linux-pci, lkml

quoted hunk ↗ jump to hunk
From: Fabio M. De Francesco <redacted>
[...]
Subject: [PATCH 3/4 v3] ACPI: extlog: Trace CPER PCI Express Error Section

I/O Machine Check Architecture events may signal failing PCIe components or
links. The AER event contains details on what was happening on the wire
when the error was signaled.

Trace the CPER PCIe Error section (UEFI v2.10, Appendix N.2.7) reported by
the I/O MCA.

Cc: Dan Williams <redacted>
Signed-off-by: Fabio M. De Francesco
[off-list ref]
[...]
--- a/drivers/acpi/acpi_extlog.c
+++ b/drivers/acpi/acpi_extlog.c
@@ -132,6 +132,34 @@ static int print_extlog_rcd(const char *pfx,
 	return 1;
 }

+static void extlog_print_pcie(struct cper_sec_pcie *pcie_err,
+			      int severity)
+{
+	struct aer_capability_regs *aer;
+	struct pci_dev *pdev;
+	unsigned int devfn;
+	unsigned int bus;
+	int aer_severity;
+	int domain;
+
+	if (!(pcie_err->validation_bits & CPER_PCIE_VALID_DEVICE_ID ||
+	      pcie_err->validation_bits & CPER_PCIE_VALID_AER_INFO))
+		return;
+
+	aer_severity = cper_severity_to_aer(severity);
+	aer = (struct aer_capability_regs *)pcie_err->aer_info;
+	domain = pcie_err->device_id.segment;
+	bus = pcie_err->device_id.bus;
+	devfn = PCI_DEVFN(pcie_err->device_id.device,
+			  pcie_err->device_id.function);
+	pdev = pci_get_domain_bus_and_slot(domain, bus, devfn);
+	if (!pdev)
+		return;
+
+	pci_print_aer(KERN_DEBUG, pdev, aer_severity, aer);
Is there any reason not to use "KERN_ERR" log level?
+	pci_dev_put(pdev);
+}
+ 
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help