Thread (8 messages) 8 messages, 3 authors, 2025-05-20

Re: [PATCH] crypto: powerpc/poly1305 - add depends on BROKEN for now

From: Christophe Leroy <hidden>
Date: 2025-05-19 14:20:35
Also in: linux-crypto, stable


Le 15/05/2025 à 04:10, Herbert Xu a écrit :
On Wed, May 14, 2025 at 09:29:33AM -0700, Eric Biggers wrote:
quoted
I didn't notice that.  Probably, though I don't have time to review this subtle
Poly1305 code.  Especially with all the weird unions in the code.  Would be
great if the PowerPC folks would take a look.
Of course more reviews would be great and I think they're all on
the cc list.

I did test this by manually forcing the conversion, which is how
I discovered that powerpc wasn't even using donna64.
As far as I can see related patches found in linux-next tree were not 
sent to linuxppc-dev@lists.ozlabs.org.

Could you resend them, and split out the introduction of 
CONFIG_ARCH_SUPPORTS_INT128 from other parts of patch "crypto: 
powerpc/poly1305 - Add SIMD fallback" and add the lib/tishift.S in the 
patch which adds CONFIG_ARCH_SUPPORTS_INT128 ?

Thanks
Christophe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help