From: Eric Biggers <ebiggers@kernel.org> Date: 2025-05-14 05:19:22
From: Eric Biggers <redacted>
As discussed in the thread containing
https://lore.kernel.org/linux-crypto/20250510053308.GB505731@sol/, the
Power10-optimized Poly1305 code is currently not safe to call in softirq
context. Disable it for now. It can be re-enabled once it is fixed.
Fixes: ba8f8624fde2 ("crypto: poly1305-p10 - Glue code for optmized Poly1305 implementation for ppc64le")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <redacted>
---
arch/powerpc/lib/crypto/Kconfig | 1 +
1 file changed, 1 insertion(+)
@@ -8,10 +8,11 @@ config CRYPTO_CHACHA20_P10selectCRYPTO_ARCH_HAVE_LIB_CHACHAconfigCRYPTO_POLY1305_P10tristatedepends onPPC64&&CPU_LITTLE_ENDIAN&&VSX+depends onBROKEN# Needs to be fixed to work in softirq contextdefaultCRYPTO_LIB_POLY1305selectCRYPTO_ARCH_HAVE_LIB_POLY1305selectCRYPTO_LIB_POLY1305_GENERICconfigCRYPTO_SHA256_PPC_SPE
From: Herbert Xu <herbert@gondor.apana.org.au> Date: 2025-05-14 09:42:02
Eric Biggers [off-list ref] wrote:
From: Eric Biggers <redacted>
As discussed in the thread containing
https://lore.kernel.org/linux-crypto/20250510053308.GB505731@sol/, the
Power10-optimized Poly1305 code is currently not safe to call in softirq
context. Disable it for now. It can be re-enabled once it is fixed.
Fixes: ba8f8624fde2 ("crypto: poly1305-p10 - Glue code for optmized Poly1305 implementation for ppc64le")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <redacted>
---
arch/powerpc/lib/crypto/Kconfig | 1 +
1 file changed, 1 insertion(+)
From: Eric Biggers <ebiggers@kernel.org> Date: 2025-05-14 16:29:39
On Wed, May 14, 2025 at 05:41:39PM +0800, Herbert Xu wrote:
Eric Biggers [off-list ref] wrote:
quoted
From: Eric Biggers <redacted>
As discussed in the thread containing
https://lore.kernel.org/linux-crypto/20250510053308.GB505731@sol/, the
Power10-optimized Poly1305 code is currently not safe to call in softirq
context. Disable it for now. It can be re-enabled once it is fixed.
Fixes: ba8f8624fde2 ("crypto: poly1305-p10 - Glue code for optmized Poly1305 implementation for ppc64le")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <redacted>
---
arch/powerpc/lib/crypto/Kconfig | 1 +
1 file changed, 1 insertion(+)
I didn't notice that. Probably, though I don't have time to review this subtle
Poly1305 code. Especially with all the weird unions in the code. Would be
great if the PowerPC folks would take a look.
- Eric
From: Herbert Xu <herbert@gondor.apana.org.au> Date: 2025-05-15 02:10:55
On Wed, May 14, 2025 at 09:29:33AM -0700, Eric Biggers wrote:
I didn't notice that. Probably, though I don't have time to review this subtle
Poly1305 code. Especially with all the weird unions in the code. Would be
great if the PowerPC folks would take a look.
Of course more reviews would be great and I think they're all on
the cc list.
I did test this by manually forcing the conversion, which is how
I discovered that powerpc wasn't even using donna64.
Cheers,
--
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Wed, May 14, 2025 at 09:29:33AM -0700, Eric Biggers wrote:
quoted
I didn't notice that. Probably, though I don't have time to review this subtle
Poly1305 code. Especially with all the weird unions in the code. Would be
great if the PowerPC folks would take a look.
Of course more reviews would be great and I think they're all on
the cc list.
I did test this by manually forcing the conversion, which is how
I discovered that powerpc wasn't even using donna64.
As far as I can see related patches found in linux-next tree were not
sent to linuxppc-dev@lists.ozlabs.org.
Could you resend them, and split out the introduction of
CONFIG_ARCH_SUPPORTS_INT128 from other parts of patch "crypto:
powerpc/poly1305 - Add SIMD fallback" and add the lib/tishift.S in the
patch which adds CONFIG_ARCH_SUPPORTS_INT128 ?
Thanks
Christophe
From: Herbert Xu <herbert@gondor.apana.org.au> Date: 2025-05-20 02:33:16
On Mon, May 19, 2025 at 03:55:16PM +0200, Christophe Leroy wrote:
As far as I can see related patches found in linux-next tree were not sent
to linuxppc-dev@lists.ozlabs.org.
I just checked and it was definitely sent to linuxppc-dev:
Cc: oe-kbuild-all@lists.linux.dev, Linux Crypto Mailing List <redacted>, Venkat Rao Bagalkote <redacted>, Madhavan Srinivasan <maddy@linux.ibm.com>, Stephen Rothwell <redacted>, Danny Tsen <redacted>, linuxppc-dev@lists.ozlabs.org, Michael Ellerman <mpe@ellerman.id.au>
Could you resend them, and split out the introduction of
CONFIG_ARCH_SUPPORTS_INT128 from other parts of patch "crypto:
powerpc/poly1305 - Add SIMD fallback" and add the lib/tishift.S in the patch
which adds CONFIG_ARCH_SUPPORTS_INT128 ?
From: Herbert Xu <herbert@gondor.apana.org.au> Date: 2025-05-20 02:41:52
On Wed, May 14, 2025 at 05:18:47AM +0000, Eric Biggers wrote:
From: Eric Biggers <redacted>
As discussed in the thread containing
https://lore.kernel.org/linux-crypto/20250510053308.GB505731@sol/, the
Power10-optimized Poly1305 code is currently not safe to call in softirq
context. Disable it for now. It can be re-enabled once it is fixed.
Fixes: ba8f8624fde2 ("crypto: poly1305-p10 - Glue code for optmized Poly1305 implementation for ppc64le")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <redacted>
---
arch/powerpc/lib/crypto/Kconfig | 1 +
1 file changed, 1 insertion(+)
On Mon, May 19, 2025 at 03:55:16PM +0200, Christophe Leroy wrote:
quoted
As far as I can see related patches found in linux-next tree were not sent
to linuxppc-dev@lists.ozlabs.org.
I just checked and it was definitely sent to linuxppc-dev:
Oops sorry, my mistake.
I see them in patchwork, they still have status 'New'.
Cc: oe-kbuild-all@lists.linux.dev, Linux Crypto Mailing List <redacted>, Venkat Rao Bagalkote <redacted>, Madhavan Srinivasan <maddy@linux.ibm.com>, Stephen Rothwell <redacted>, Danny Tsen <redacted>, linuxppc-dev@lists.ozlabs.org, Michael Ellerman <mpe@ellerman.id.au>
quoted
Could you resend them, and split out the introduction of
CONFIG_ARCH_SUPPORTS_INT128 from other parts of patch "crypto:
powerpc/poly1305 - Add SIMD fallback" and add the lib/tishift.S in the patch
which adds CONFIG_ARCH_SUPPORTS_INT128 ?
I'll just revert them and mark powerpc/poly1305 as broken. You
guys can sort it out later.
Fine, lets do that and make sure all necessary bits are there when
enabling CONFIG_ARCH_SUPPORTS_INT128
Thanks
Christophe