Thread (21 messages) 21 messages, 7 authors, 2025-03-06

Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP

From: George Cherian <gcherian@marvell.com>
Date: 2025-03-05 10:36:44
Also in: chrome-platform, imx, linux-arm-kernel, linux-mips, linux-watchdog, lkml, openbmc

From: Marek Behún <kabel@kernel.org> 
Sent: Wednesday, March 5, 2025 3:48 PM
To: George Cherian <gcherian@marvell.com>
Cc: linux@roeck-us.net; wim@linux-watchdog.org; jwerner@chromium.org; evanbenn@chromium.org; krzk@kernel.org; mazziesaccount@gmail.com; thomas.richard@bootlin.com; lma@chromium.org; bleung@chromium.org; support.opensource@diasemi.com; shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; andy@kernel.org; paul@crapouillou.net; alexander.usyskin@intel.com; andreas.werner@men.de; daniel@thingy.jp; romain.perier@gmail.com; avifishman70@gmail.com; tmaimon77@gmail.com; tali.perry1@gmail.com; venture@google.com; yuenn@google.com; benjaminfair@google.com; maddy@linux.ibm.com; mpe@ellerman.id.au; npiggin@gmail.com; christophe.leroy@csgroup.eu; naveen@kernel.org; mwalle@kernel.org; xingyu.wu@starfivetech.com; ziv.xu@starfivetech.com; hayashi.kunihiko@socionext.com; mhiramat@kernel.org; linux-watchdog@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; chrome-platform@lists.linux.dev; imx@lists.linux.dev; linux-mips@vger.kernel.org; openbmc@lists.ozlabs.org; linuxppc-dev@lists.ozlabs.org; patches@opensource.cirrus.com
Subject: Re: [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP
Hi George,

why is armada_37xx_wdt also here?
The stop function in that driver may not sleep.
Marek,

Thanks for reviewing.
Since the stop function has a regmap_write(), I thought it might sleep.
Now that you pointed it out, I assume that it is an MMIO based regmap being used for armada.
I will update the same in the next version
Marek
-George
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help