Thread (21 messages) 21 messages, 7 authors, 2025-03-06

Re: [PATCH v4 2/2] drivers: watchdog: Add support for panic notifier callback

From: Andy Shevchenko <andy@kernel.org>
Date: 2025-03-05 10:33:56
Also in: chrome-platform, imx, linux-arm-kernel, linux-mips, linux-watchdog, lkml, openbmc

On Wed, Mar 05, 2025 at 10:10:25AM +0000, George Cherian wrote:
Watchdog is not turned off in kernel panic situation.
In certain systems this might prevent the successful loading
of kdump kernel. The kdump kernel might hit a watchdog reset
while it is booting.

To avoid such scenarios add a panic notifier call back function
which can stop the watchdog. This provision can be enabled by
passing watchdog.stop_on_panic=1 via kernel command-line parameter.
...

First of all, do we really need a new module parameter for that? Why can't it
be done automatically if kdump is expected?
+static bool stop_on_panic;
+module_param(stop_on_panic, bool, 0444);
+MODULE_PARM_DESC(stop_on_panic, "Stop watchdogs on panic (0=keep watching, 1=stop)");
+ blank line.

Also I do not see the documentation update. Where is it lost?
 /*
-- 
With Best Regards,
Andy Shevchenko


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help