Re: [PATCH v3 3/3] dt-bindings: memory-controllers: Convert fsl,elbc to YAML
From: "Rob Herring (Arm)" <robh@kernel.org>
Date: 2025-02-26 18:45:21
Also in:
linux-devicetree, lkml
On Wed, 26 Feb 2025 18:01:42 +0100, J. Neuschäfer wrote:
Convert the Freescale localbus controller bindings from text form to YAML. Compared to the .txt version, the YAML binding contains a new usage example with FCM NAND flash, and a full list of compatible strings based on current usage in arch/powerpc/boot/dts/. Note that the both the compatible strings and the unit address format are kept as-is, for compatibility with existing kernels and device trees, as well as unit address readability. This results in dts validation warnings: Warning (simple_bus_reg): /example-0/localbus@f0010100/board-control@1,0: simple-bus unit address format error, expected "100000000" Signed-off-by: J. Neuschäfer <redacted> --- V3: - move this patch after the GPCM/FCM patches to dtschema/dtc warnings due to missing bindings for fsl,elbc-gpcm-uio and fsl,elbc-fcm-nand - add "simple-bus" again, for compatibility with existing DTs/drivers based on discussion with Crystal Wood and Rob Herring - fix fsl,pq2-localbus compatible properties based on mgcoge.dts / ep8248e.dts (was missing "simple-bus") - add board-control (bcsr) example again, now using the compatible string listed in Documentation/devicetree/bindings/board/fsl,bcsr.yaml - remove interrupt-parent property from example - rework the commit message V2: - fix order of properties in examples, according to dts coding style - move to Documentation/devicetree/bindings/memory-controllers - clarify the commit message a tiny bit - remove unnecessary multiline markers (|) - define address format in patternProperties - trim subject line (remove "binding") - remove use of "simple-bus", because it's technically incorrect --- .../bindings/memory-controllers/fsl,elbc.yaml | 158 +++++++++++++++++++++ .../devicetree/bindings/powerpc/fsl/lbc.txt | 43 ------ 2 files changed, 158 insertions(+), 43 deletions(-)
My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/memory-controllers/fsl,elbc.example.dts:29.23-34.15: Warning (simple_bus_reg): /example-0/localbus@f0010100/flash@0,0: simple-bus unit address format error, expected "0" Documentation/devicetree/bindings/memory-controllers/fsl,elbc.example.dts:36.31-39.15: Warning (simple_bus_reg): /example-0/localbus@f0010100/board-control@1,0: simple-bus unit address format error, expected "100000000" Documentation/devicetree/bindings/memory-controllers/fsl,elbc.example.dts:41.31-46.15: Warning (simple_bus_reg): /example-0/localbus@f0010100/simple-periph@2,0: simple-bus unit address format error, expected "200000000" Documentation/devicetree/bindings/memory-controllers/fsl,elbc.example.dts:82.23-89.15: Warning (simple_bus_reg): /example-1/localbus@e0005000/flash@0,0: simple-bus unit address format error, expected "0" Documentation/devicetree/bindings/memory-controllers/fsl,elbc.example.dts:91.22-97.15: Warning (simple_bus_reg): /example-1/localbus@e0005000/nand@1,0: simple-bus unit address format error, expected "100000000" /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/memory-controllers/fsl,elbc.example.dtb: nand@1,0: $nodename:0: 'nand@1,0' does not match '^nand@[a-f0-9]$' from schema $id: http://devicetree.org/schemas/mtd/fsl,elbc-fcm-nand.yaml# doc reference errors (make refcheckdocs): Warning: Documentation/devicetree/bindings/display/ssd1289fb.txt references a file that doesn't exist: Documentation/devicetree/bindings/powerpc/fsl/lbc.txt Documentation/devicetree/bindings/display/ssd1289fb.txt: Documentation/devicetree/bindings/powerpc/fsl/lbc.txt See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250226-ppcyaml-elbc-v3-3-a90ed71da838@posteo.net The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.