Re: [RESEND PATCH] fadump: Use str_yes_no() helper in fadump_show_config()
From: Christophe Leroy <hidden>
Date: 2025-02-09 09:50:09
Also in:
lkml
Hi, Le 09/02/2025 à 09:17, Thorsten Blum a écrit :
Remove hard-coded strings by using the str_yes_no() helper function. Reviewed-by: Sourabh Jain <redacted> Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Any reason for resending ? Your patch is not lost, see https://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=89400 If there is a reason that you don't want to put in the commit message, just put it here below under the ---
quoted hunk ↗ jump to hunk
--- arch/powerpc/kernel/fadump.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c index 4b371c738213..8c531533dd3e 100644 --- a/arch/powerpc/kernel/fadump.c +++ b/arch/powerpc/kernel/fadump.c@@ -289,10 +289,8 @@ static void __init fadump_show_config(void) if (!fw_dump.fadump_supported) return; - pr_debug("Fadump enabled : %s\n", - (fw_dump.fadump_enabled ? "yes" : "no")); - pr_debug("Dump Active : %s\n", - (fw_dump.dump_active ? "yes" : "no")); + pr_debug("Fadump enabled : %s\n", str_yes_no(fw_dump.fadump_enabled)); + pr_debug("Dump Active : %s\n", str_yes_no(fw_dump.dump_active)); pr_debug("Dump section sizes:\n"); pr_debug(" CPU state data size: %lx\n", fw_dump.cpu_state_data_size); pr_debug(" HPTE region size : %lx\n", fw_dump.hpte_region_size);