[RESEND PATCH] fadump: Use str_yes_no() helper in fadump_show_config()

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE538d REVIEWED: 3 (2M)

2 review trailers.

3 messages, 2 authors, 2025-02-09 · open the first message on its own page

[RESEND PATCH] fadump: Use str_yes_no() helper in fadump_show_config()

From: Thorsten Blum <thorsten.blum@linux.dev>
Date: 2025-02-09 08:17:32

Remove hard-coded strings by using the str_yes_no() helper function.

Reviewed-by: Sourabh Jain <redacted>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 arch/powerpc/kernel/fadump.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
index 4b371c738213..8c531533dd3e 100644
--- a/arch/powerpc/kernel/fadump.c
+++ b/arch/powerpc/kernel/fadump.c
@@ -289,10 +289,8 @@ static void __init fadump_show_config(void)
 	if (!fw_dump.fadump_supported)
 		return;
 
-	pr_debug("Fadump enabled    : %s\n",
-				(fw_dump.fadump_enabled ? "yes" : "no"));
-	pr_debug("Dump Active       : %s\n",
-				(fw_dump.dump_active ? "yes" : "no"));
+	pr_debug("Fadump enabled    : %s\n", str_yes_no(fw_dump.fadump_enabled));
+	pr_debug("Dump Active       : %s\n", str_yes_no(fw_dump.dump_active));
 	pr_debug("Dump section sizes:\n");
 	pr_debug("    CPU state data size: %lx\n", fw_dump.cpu_state_data_size);
 	pr_debug("    HPTE region size   : %lx\n", fw_dump.hpte_region_size);
-- 
2.48.1

Re: [RESEND PATCH] fadump: Use str_yes_no() helper in fadump_show_config()

From: Christophe Leroy <hidden>
Date: 2025-02-09 09:50:09

Hi,

Le 09/02/2025 à 09:17, Thorsten Blum a écrit :
Remove hard-coded strings by using the str_yes_no() helper function.

Reviewed-by: Sourabh Jain <redacted>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Any reason for resending ? Your patch is not lost, see 
https://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=89400

If there is a reason that you don't want to put in the commit message, 
just put it here below under the ---
quoted hunk
---
  arch/powerpc/kernel/fadump.c | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
index 4b371c738213..8c531533dd3e 100644
--- a/arch/powerpc/kernel/fadump.c
+++ b/arch/powerpc/kernel/fadump.c
@@ -289,10 +289,8 @@ static void __init fadump_show_config(void)
  	if (!fw_dump.fadump_supported)
  		return;
  
-	pr_debug("Fadump enabled    : %s\n",
-				(fw_dump.fadump_enabled ? "yes" : "no"));
-	pr_debug("Dump Active       : %s\n",
-				(fw_dump.dump_active ? "yes" : "no"));
+	pr_debug("Fadump enabled    : %s\n", str_yes_no(fw_dump.fadump_enabled));
+	pr_debug("Dump Active       : %s\n", str_yes_no(fw_dump.dump_active));
  	pr_debug("Dump section sizes:\n");
  	pr_debug("    CPU state data size: %lx\n", fw_dump.cpu_state_data_size);
  	pr_debug("    HPTE region size   : %lx\n", fw_dump.hpte_region_size);

Re: [RESEND PATCH] fadump: Use str_yes_no() helper in fadump_show_config()

From: Thorsten Blum <thorsten.blum@linux.dev>
Date: 2025-02-09 10:01:20

On 9. Feb 2025, at 10:16, Christophe Leroy wrote:
Le 09/02/2025 à 09:17, Thorsten Blum a écrit :
quoted
Remove hard-coded strings by using the str_yes_no() helper function.
Reviewed-by: Sourabh Jain <redacted>
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Any reason for resending ? Your patch is not lost, see https://patchwork.ozlabs.org/project/linuxppc-dev/list/?submitter=89400
Ah sorry, I missed this. It's sometimes hard to know the status of a
patch when it's not in next yet.

Thanks,
Thorsten
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help