-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: 2025年1月16日 10:41
To: Wei Fang <wei.fang@nxp.com>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>; Vladimir Oltean
[off-list ref]; Clark Wang [off-list ref];
andrew+netdev@lunn.ch; davem@davemloft.net; edumazet@google.com;
pabeni@redhat.com; christophe.leroy@csgroup.eu; netdev@vger.kernel.org;
linux-kernel@vger.kernel.org; linuxppc-dev@lists.ozlabs.org;
linux-arm-kernel@lists.infradead.org; imx@lists.linux.dev
Subject: Re: [PATCH v2 net-next 07/13] net: enetc: add RSS support for i.MX95
ENETC PF

On Thu, 16 Jan 2025 02:24:10 +0000 Wei Fang wrote:

quoted

quoted

Why create full ops for something this trivial?

We add enetc_pf_hw_ops to implement different hardware ops
for different chips. So that they can be called in common functions.
Although the change is minor, it is consistent with the original
intention of adding enetc_pf_hw_ops.

In other words you prefer ops.

Now imagine you have to refactor such piece of code in 10 drivers
and each of them has 2 layers of indirect ops like you do.
Unnecessary complexity.

Okay, I will remove them from ops.