Thread (18 messages) 18 messages, 2 authors, 2025-01-16

Re: [PATCH v2 net-next 07/13] net: enetc: add RSS support for i.MX95 ENETC PF

From: Jakub Kicinski <kuba@kernel.org>
Date: 2025-01-16 02:41:07
Also in: imx, linux-arm-kernel, lkml, netdev

On Thu, 16 Jan 2025 02:24:10 +0000 Wei Fang wrote:
quoted
Why create full ops for something this trivial?  
We add enetc_pf_hw_ops to implement different hardware ops
for different chips. So that they can be called in common functions.
Although the change is minor, it is consistent with the original
intention of adding enetc_pf_hw_ops.
In other words you prefer ops.

Now imagine you have to refactor such piece of code in 10 drivers 
and each of them has 2 layers of indirect ops like you do.
Unnecessary complexity.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help