On Fri, Jan 10, 2025 at 04:24:27PM +0100, Krzysztof Kozlowski wrote:
On 02/01/2025 19:31, J. Neuschäfer via B4 Relay wrote:
[...]
quoted
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/input/input.h>
+
+/ {
+ compatible = "lancom,nwapp2", "fsl,mpc8314e";
Missing bindings. Please run scripts/checkpatch.pl and fix reported
warnings. After that, run also `scripts/checkpatch.pl --strict` and
(probably) fix more warnings. Some warnings can be ignored, especially
from --strict run, but the code here looks like it needs a fix. Feel
free to get in touch if the warning is not clear.
Alright, I'll write the bindings.
quoted
+ model = "LANCOM NWAPP2";
+
+ memory {
+ reg = <0x00000000 0x08000000>; // 128MB at 0
+ };
[...]
quoted
+&localbus {
+ status = "okay";
+ ranges = <0x0 0x0 0xfe000000 0x00008000>;
+
+ nand@0,0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "fsl,mpc8315-fcm-nand",
Compatible is always the first property.
quoted
+ "fsl,elbc-fcm-nand";
+ reg = <0x0 0x0 0x2000>;
reg follows.
Ok, will fix.