Re: [PATCH 16/19] powerpc: dts: Add LANCOM NWAPP2 board devicetree
- From
- Krzysztof Kozlowski <krzk@kernel.org>
- Date
- 2025-01-10 15:24:36
- Also in
- linux-devicetree, linux-gpio, lkml
- Reply to
- J. Neuschäfer via B4 Relay, 2025-01-02
On 02/01/2025 19:31, J. Neuschäfer via B4 Relay wrote:
quoted hunk ↗ jump to hunk
arch/powerpc/boot/dts/Makefile | 1 + arch/powerpc/boot/dts/lancom-nwapp2.dts | 276 ++++++++++++++++++++++++++++++++ 2 files changed, 277 insertions(+)diff --git a/arch/powerpc/boot/dts/Makefile b/arch/powerpc/boot/dts/Makefile index 6aee895d5baaa2c978d4b1c82a6d198d9e166ea2..43e20d8b776b1716a91e6ec8e135c0a45c8e8c77 100644 --- a/arch/powerpc/boot/dts/Makefile +++ b/arch/powerpc/boot/dts/Makefile@@ -6,5 +6,6 @@ dtb-$(CONFIG_OF_ALL_DTBS) := $(patsubst $(src)/%.dts,%.dtb, $(wildcard $(src)/*. dtb-$(CONFIG_MPC831x) += \ kmeter1.dtb \ + lancom-nwapp2.dtb \ mpc8313erdb.dtb \ mpc8315erdb.dtbdiff --git a/arch/powerpc/boot/dts/lancom-nwapp2.dts b/arch/powerpc/boot/dts/lancom-nwapp2.dts new file mode 100644 index 0000000000000000000000000000000000000000..d46d94c27ecb91db32c8acb4136cb6e8d0df52f5 --- /dev/null +++ b/arch/powerpc/boot/dts/lancom-nwapp2.dts@@ -0,0 +1,276 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +// Copyright 2024 J. Neuschäfer +// +// LANCOM NWAPP2, marketed as: +// - LANCOM L-321agn Wireless (R2) +// - LANCOM L-322agn dual Wireless (R2) +// - LANCOM L-322E Wireless +#include "mpc8314e.dtsi" + +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/leds/common.h> +#include <dt-bindings/input/input.h> + +/ { + compatible = "lancom,nwapp2", "fsl,mpc8314e";
Missing bindings. Please run scripts/checkpatch.pl and fix reported
warnings. After that, run also `scripts/checkpatch.pl --strict` and
(probably) fix more warnings. Some warnings can be ignored, especially
from --strict run, but the code here looks like it needs a fix. Feel
free to get in touch if the warning is not clear.
quoted hunk ↗ jump to hunk
+ model = "LANCOM NWAPP2"; + + memory { + reg = <0x00000000 0x08000000>; // 128MB at 0 + };
...
quoted hunk ↗ jump to hunk
+ + led-power-top { + label = "multicolor:power-top"; + compatible = "leds-group-multicolor"; + color = <LED_COLOR_ID_MULTI>; + function = LED_FUNCTION_POWER; + leds = <&led_power_top_red>, <&led_power_top_green>; + }; + + led-wlan-top { + label = "multicolor:wlan-top"; + compatible = "leds-group-multicolor"; + color = <LED_COLOR_ID_MULTI>; + leds = <&led_wlan_top_red>, <&led_wlan_top_green>; + }; +}; + +&gpio { + gpio-line-names = + /* 0 - 7 */ "DEBUG#", "RESET_BTN#", "", "EXP_LATCH", "", "", "", "PCIE_RST#", + /* 8 - 15 */ "", "", "BOARD_RST", "", "", "", "", "", + /* 16 - 23 */ "", "", "WDT_TOGGLE", "", "", "", "PHY_RST#", "", + /* 24 - 31 */ "", "", "", "", "", "", "", ""; +}; + +&localbus { + status = "okay"; + ranges = <0x0 0x0 0xfe000000 0x00008000>; + + nand@0,0 { + #address-cells = <1>; + #size-cells = <1>; + compatible = "fsl,mpc8315-fcm-nand",
Compatible is always the first property.
+ "fsl,elbc-fcm-nand"; + reg = <0x0 0x0 0x2000>;
reg follows.
quoted hunk ↗ jump to hunk
+ + partitions { + compatible = "fixed-partitions"; + #address-cells = <1>; + #size-cells = <1>; +
Best regards, Krzysztof