Re: [PATCH v6 1/8] PCI: Don't expose pcie_read_tlp_log() outside of PCI subsystem
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Date: 2024-12-11 16:22:12
Also in:
linux-pci, lkml
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Date: 2024-12-11 16:22:12
Also in:
linux-pci, lkml
On Fri, 13 Sep 2024 17:36:25 +0300 Ilpo Järvinen [off-list ref] wrote:
pcie_read_tlp_log() was exposed by the commit 0a5a46a6a61b ("PCI/AER:
Generalize TLP Header Log reading") but this is now considered a
mistake. No drivers outside of PCI subsystem should build their own
diagnostic logging but should rely on PCI core doing it for them.
There's currently one driver (ixgbe) doing it independently which was
the initial reason why the export was added but it was decided by the
PCI maintainer that it's something that should be eliminated.
Remove the unwanted EXPORT of pcie_read_tlp_log() and remove it from
include/linux/aer.h.
Link: https://lore.kernel.org/all/20240322193011.GA701027@bhelgaas/ (local)
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>FWIW LGTM Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>