Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages
From: Mike Rapoport <rppt@kernel.org>
Date: 2024-10-14 13:11:32
Also in:
bpf, linux-alpha, linux-arch, linux-m68k, linux-mips, linux-mm, linux-modules, linux-riscv, linux-sh, linux-trace-kernel, linux-um, lkml, loongarch, sparclinux
On Sun, Oct 13, 2024 at 10:55:25PM -0700, Christoph Hellwig wrote:
On Sun, Oct 13, 2024 at 11:43:41AM +0300, Mike Rapoport wrote:quoted
quoted
But why? That's pretty different from our normal style of arch hooks, and introduces an indirect call in a security sensitive area.Will change to __weak hook.Isn't the callback required when using the large ROX page? I.e. shouldn't it be an unconditional callback and not a weak override?
I'll add a Kconfig option to ensure that an architecture that wants to use large ROX pages has explicit callback for that. -- Sincerely yours, Mike.