Re: [PATCH v5 1/8] mm: vmalloc: group declarations depending on CONFIG_MMU together

[PATCH v5 0/8] x86/module: use large ROX pages for text allocations · Mike Rapoport <rppt@kernel.org> · 2024-10-09
[PATCH v5 1/8] mm: vmalloc: group declarations depending on CONFIG_MMU together · Mike Rapoport <rppt@kernel.org> · 2024-10-09
Re: [PATCH v5 1/8] mm: vmalloc: group declarations depending on CONFIG_MMU together · Christoph Hellwig <hch@infradead.org> · 2024-10-10
[PATCH v5 2/8] mm: vmalloc: don't account for number of nodes for HUGE_VMAP allocations · Mike Rapoport <rppt@kernel.org> · 2024-10-09
Re: [PATCH v5 2/8] mm: vmalloc: don't account for number of nodes for HUGE_VMAP allocations · Christoph Hellwig <hch@infradead.org> · 2024-10-10
[PATCH v5 3/8] asm-generic: introduce text-patching.h · Mike Rapoport <rppt@kernel.org> · 2024-10-09
Re: [PATCH v5 3/8] asm-generic: introduce text-patching.h · Christoph Hellwig <hch@infradead.org> · 2024-10-10
Re: [PATCH v5 3/8] asm-generic: introduce text-patching.h · Geert Uytterhoeven <geert@linux-m68k.org> · 2024-10-10
Re: [PATCH v5 3/8] asm-generic: introduce text-patching.h · "Arnd Bergmann" <arnd@arndb.de> · 2024-10-10
[PATCH v5 4/8] module: prepare to handle ROX allocations for text · Mike Rapoport <rppt@kernel.org> · 2024-10-09
Re: [PATCH v5 4/8] module: prepare to handle ROX allocations for text · Song Liu <song@kernel.org> · 2024-10-09
Re: [PATCH v5 4/8] module: prepare to handle ROX allocations for text · Mike Rapoport <rppt@kernel.org> · 2024-10-10
Re: [PATCH v5 4/8] module: prepare to handle ROX allocations for text · Song Liu <song@kernel.org> · 2024-10-10
[PATCH v5 5/8] arch: introduce set_direct_map_valid_noflush() · Mike Rapoport <rppt@kernel.org> · 2024-10-09
Re: [PATCH v5 5/8] arch: introduce set_direct_map_valid_noflush() · Christoph Hellwig <hch@infradead.org> · 2024-10-10
[PATCH v5 6/8] x86/module: perpare module loading for ROX allocations of text · Mike Rapoport <rppt@kernel.org> · 2024-10-09
Re: [PATCH v5 6/8] x86/module: perpare module loading for ROX allocations of text · Christoph Hellwig <hch@infradead.org> · 2024-10-10
Re: [PATCH v5 6/8] x86/module: perpare module loading for ROX allocations of text · Nathan Chancellor <nathan@kernel.org> · 2024-10-10
Re: [PATCH v5 6/8] x86/module: perpare module loading for ROX allocations of text · Mike Rapoport <rppt@kernel.org> · 2024-10-11
Re: [PATCH v5 6/8] x86/module: perpare module loading for ROX allocations of text · Nathan Chancellor <nathan@kernel.org> · 2024-10-15
[PATCH v5 7/8] execmem: add support for cache of large ROX pages · Mike Rapoport <rppt@kernel.org> · 2024-10-09
Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages · Andrew Morton <akpm@linux-foundation.org> · 2024-10-09
Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages · Mike Rapoport <rppt@kernel.org> · 2024-10-10
Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages · Christoph Hellwig <hch@infradead.org> · 2024-10-10
Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages · Mike Rapoport <rppt@kernel.org> · 2024-10-10
Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages · Christoph Hellwig <hch@infradead.org> · 2024-10-11
Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages · Mike Rapoport <rppt@kernel.org> · 2024-10-13
Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages · Andrew Morton <akpm@linux-foundation.org> · 2024-10-14
Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages · Luis Chamberlain <mcgrof@kernel.org> · 2024-10-14
Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages · Luis Chamberlain <mcgrof@kernel.org> · 2024-10-15
Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages · Mike Rapoport <rppt@kernel.org> · 2024-10-15
Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages · Luis Chamberlain <mcgrof@kernel.org> · 2024-10-15
Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages · Mike Rapoport <rppt@kernel.org> · 2024-10-16
Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages · Luis Chamberlain <mcgrof@kernel.org> · 2024-10-16
Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages · Christoph Hellwig <hch@infradead.org> · 2024-10-14
Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages · Mike Rapoport <rppt@kernel.org> · 2024-10-14
Re: [PATCH v5 7/8] execmem: add support for cache of large ROX pages · Kees Bakker <hidden> · 2024-10-10
[PATCH v5 8/8] x86/module: enable ROX caches for module text · Mike Rapoport <rppt@kernel.org> · 2024-10-09
Bisected: [PATCH v5 8/8] x86/module: enable ROX caches for module text · Sergey Senozhatsky <senozhatsky@chromium.org> · 2024-10-10
Re: Bisected: [PATCH v5 8/8] x86/module: enable ROX caches for module text · Mike Rapoport <rppt@kernel.org> · 2024-10-10

From: Christoph Hellwig <hch@infradead.org>
Date: 2024-10-10 06:54:36
Also in: bpf, linux-alpha, linux-arch, linux-m68k, linux-mips, linux-mm, linux-modules, linux-riscv, linux-sh, linux-trace-kernel, linux-um, lkml, loongarch, sparclinux

On Wed, Oct 09, 2024 at 09:08:09PM +0300, Mike Rapoport wrote:

+/* for /proc/kcore */
+extern long vread_iter(struct iov_iter *iter, const char *addr, size_t count);
+
+/*
+ *	Internals.  Don't use..
+ */
+extern __init void vm_area_add_early(struct vm_struct *vm);
+extern __init void vm_area_register_early(struct vm_struct *vm, size_t align);

Please drop the externs while you're at it. (one more down below)

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help