Re: [PATCH v4 19/29] arm64: enable PKEY support for CPUs with S1POE
From: Dave Martin <Dave.Martin@arm.com>
Date: 2024-07-25 16:00:54
Also in:
kvmarm, linux-arm-kernel, linux-fsdevel, linux-mm
Hi, On Fri, May 03, 2024 at 02:01:37PM +0100, Joey Gouly wrote:
quoted hunk ↗ jump to hunk
Now that PKEYs support has been implemented, enable it for CPUs that support S1POE. Signed-off-by: Joey Gouly <joey.gouly@arm.com> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will@kernel.org> Acked-by: Catalin Marinas <catalin.marinas@arm.com> --- arch/arm64/include/asm/pkeys.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/arm64/include/asm/pkeys.h b/arch/arm64/include/asm/pkeys.h index a284508a4d02..3ea928ec94c0 100644 --- a/arch/arm64/include/asm/pkeys.h +++ b/arch/arm64/include/asm/pkeys.h@@ -17,7 +17,7 @@ int arch_set_user_pkey_access(struct task_struct *tsk, int pkey, static inline bool arch_pkeys_enabled(void) { - return false; + return system_supports_poe(); }
Nit: maybe push this later in the series, at least to after the POE/PIE patch, since pkeys won't work right otherwise on PIE-enabled platforms? (I know it makes no difference without final Kconfig update, but it feels more logical.) [...] Cheers ---Dave