Thread (35 messages) flat view 35 messages, 11 authors, 2024-07-08

Re: [PATCH 09/20] gpio: brcmstb: convert to of_property_for_each_u32_new()

From: Bartosz Golaszewski <hidden>
Date: 2024-07-03 11:34:05
Also in: linux-arm-msm, linux-clk, linux-devicetree, linux-gpio, linux-iio, linux-omap, linux-pwm, linux-riscv, linux-samsung-soc, linux-serial, linux-sound, linux-sunxi, linux-usb, lkml, llvm

On Wed, Jul 3, 2024 at 12:38 PM Luca Ceresoli [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Simplify code using of_property_for_each_u32_new() as the two additional
parameters in of_property_for_each_u32() are not used here.

Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
 drivers/gpio/gpio-brcmstb.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
index 8dce78ea7139..77557bc596cd 100644
--- a/drivers/gpio/gpio-brcmstb.c
+++ b/drivers/gpio/gpio-brcmstb.c
@@ -591,8 +591,6 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
        void __iomem *reg_base;
        struct brcmstb_gpio_priv *priv;
        struct resource *res;
-       struct property *prop;
-       const __be32 *p;
        u32 bank_width;
        int num_banks = 0;
        int num_gpios = 0;
@@ -636,8 +634,7 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
        flags = BGPIOF_BIG_ENDIAN_BYTE_ORDER;
 #endif

-       of_property_for_each_u32(np, "brcm,gpio-bank-widths", prop, p,
-                       bank_width) {
+       of_property_for_each_u32_new(np, "brcm,gpio-bank-widths", bank_width) {
                struct brcmstb_gpio_bank *bank;
                struct gpio_chip *gc;


--
2.34.1
Acked-by: Bartosz Golaszewski <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help