Thread (35 messages) 35 messages, 11 authors, 2024-07-08

Re: [PATCH 17/20] ASoC: arizona: convert to of_property_for_each_u32_new()

From: Richard Fitzgerald <rf@opensource.cirrus.com>
Date: 2024-07-03 11:31:37
Also in: linux-arm-msm, linux-clk, linux-devicetree, linux-gpio, linux-iio, linux-omap, linux-pwm, linux-riscv, linux-samsung-soc, linux-serial, linux-sound, linux-sunxi, linux-usb, lkml, llvm

On 03/07/2024 11:37, Luca Ceresoli wrote:
quoted hunk ↗ jump to hunk
Simplify code using of_property_for_each_u32_new() as the two additional
parameters in of_property_for_each_u32() are not used here.

Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
  sound/soc/codecs/arizona.c | 12 +++++-------
  1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/sound/soc/codecs/arizona.c b/sound/soc/codecs/arizona.c
index 7434aeeda292..1a64b9815809 100644
--- a/sound/soc/codecs/arizona.c
+++ b/sound/soc/codecs/arizona.c
@@ -2786,15 +2786,13 @@ int arizona_of_get_audio_pdata(struct arizona *arizona)
  {
  	struct arizona_pdata *pdata = &arizona->pdata;
  	struct device_node *np = arizona->dev->of_node;
-	struct property *prop;
-	const __be32 *cur;
  	u32 val;
  	u32 pdm_val[ARIZONA_MAX_PDM_SPK];
  	int ret;
  	int count = 0;
  
  	count = 0;
-	of_property_for_each_u32(np, "wlf,inmode", prop, cur, val) {
+	of_property_for_each_u32_new(np, "wlf,inmode", val) {
  		if (count == ARRAY_SIZE(pdata->inmode))
  			break;
  
@@ -2803,7 +2801,7 @@ int arizona_of_get_audio_pdata(struct arizona *arizona)
  	}
  
  	count = 0;
-	of_property_for_each_u32(np, "wlf,dmic-ref", prop, cur, val) {
+	of_property_for_each_u32_new(np, "wlf,dmic-ref", val) {
  		if (count == ARRAY_SIZE(pdata->dmic_ref))
  			break;
  
@@ -2812,7 +2810,7 @@ int arizona_of_get_audio_pdata(struct arizona *arizona)
  	}
  
  	count = 0;
-	of_property_for_each_u32(np, "wlf,out-mono", prop, cur, val) {
+	of_property_for_each_u32_new(np, "wlf,out-mono", val) {
  		if (count == ARRAY_SIZE(pdata->out_mono))
  			break;
  
@@ -2821,7 +2819,7 @@ int arizona_of_get_audio_pdata(struct arizona *arizona)
  	}
  
  	count = 0;
-	of_property_for_each_u32(np, "wlf,max-channels-clocked", prop, cur, val) {
+	of_property_for_each_u32_new(np, "wlf,max-channels-clocked", val) {
  		if (count == ARRAY_SIZE(pdata->max_channels_clocked))
  			break;
  
@@ -2830,7 +2828,7 @@ int arizona_of_get_audio_pdata(struct arizona *arizona)
  	}
  
  	count = 0;
-	of_property_for_each_u32(np, "wlf,out-volume-limit", prop, cur, val) {
+	of_property_for_each_u32_new(np, "wlf,out-volume-limit", val) {
  		if (count == ARRAY_SIZE(pdata->out_vol_limit))
  			break;
  
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help