Re: [PATCH 14/26] block: move the nonrot flag to queue_limits
From: Christoph Hellwig <hch@lst.de>
Date: 2024-06-24 17:24:30
Also in:
ceph-devel, dm-devel, linux-bcache, linux-block, linux-m68k, linux-mmc, linux-nvme, linux-raid, linux-s390, linux-scsi, linux-um, nvdimm, virtualization, xen-devel
On Mon, Jun 24, 2024 at 11:08:16AM -0600, Keith Busch wrote:
On Mon, Jun 17, 2024 at 08:04:41AM +0200, Christoph Hellwig wrote:quoted
-#define blk_queue_nonrot(q) test_bit(QUEUE_FLAG_NONROT, &(q)->queue_flags) +#define blk_queue_nonrot(q) ((q)->limits.features & BLK_FEAT_ROTATIONAL)This is inverted. Should be: #define blk_queue_nonrot(q) (!((q)->limits.features & BLK_FEAT_ROTATIONAL))
Ah yes. And the sysfs attribute doesn't go through the macro and won't show the effect. I'll send a fixup.