Re: [PATCH 14/26] block: move the nonrot flag to queue_limits

move features flags into queue_limits v2 · Christoph Hellwig <hch@lst.de> · 2024-06-17
[PATCH 01/26] xen-blkfront: don't disable cache flushes when they fail · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 01/26] xen-blkfront: don't disable cache flushes when they fail · Roger Pau Monné <roger.pau@citrix.com> · 2024-06-17
Re: [PATCH 01/26] xen-blkfront: don't disable cache flushes when they fail · Hannes Reinecke <hare@suse.de> · 2024-06-17
[PATCH 02/26] sd: remove sd_is_zoned · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 02/26] sd: remove sd_is_zoned · Chaitanya Kulkarni <hidden> · 2024-06-18
[PATCH 03/26] sd: move zone limits setup out of sd_read_block_characteristics · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 03/26] sd: move zone limits setup out of sd_read_block_characteristics · Damien Le Moal <dlemoal@kernel.org> · 2024-06-17
Re: [PATCH 03/26] sd: move zone limits setup out of sd_read_block_characteristics · Hannes Reinecke <hare@suse.de> · 2024-06-17
[PATCH 04/26] loop: stop using loop_reconfigure_limits in __loop_clr_fd · Christoph Hellwig <hch@lst.de> · 2024-06-17
[PATCH 05/26] loop: always update discard settings in loop_reconfigure_limits · Christoph Hellwig <hch@lst.de> · 2024-06-17
[PATCH 06/26] loop: regularize upgrading the block size for direct I/O · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 06/26] loop: regularize upgrading the block size for direct I/O · Damien Le Moal <dlemoal@kernel.org> · 2024-06-17
[PATCH 07/26] loop: also use the default block size from an underlying block device · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 07/26] loop: also use the default block size from an underlying block device · Damien Le Moal <dlemoal@kernel.org> · 2024-06-17
[PATCH 08/26] loop: fold loop_update_rotational into loop_reconfigure_limits · Christoph Hellwig <hch@lst.de> · 2024-06-17
[PATCH 09/26] virtio_blk: remove virtblk_update_cache_mode · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 09/26] virtio_blk: remove virtblk_update_cache_mode · Chaitanya Kulkarni <hidden> · 2024-06-18
[PATCH 10/26] nbd: move setting the cache control flags to __nbd_set_size · Christoph Hellwig <hch@lst.de> · 2024-06-17
[PATCH 11/26] block: freeze the queue in queue_attr_store · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 11/26] block: freeze the queue in queue_attr_store · Chaitanya Kulkarni <hidden> · 2024-06-18
[PATCH 12/26] block: remove blk_flush_policy · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 12/26] block: remove blk_flush_policy · Chaitanya Kulkarni <hidden> · 2024-06-18
[PATCH 13/26] block: move cache control settings out of queue->flags · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 13/26] block: move cache control settings out of queue->flags · Damien Le Moal <dlemoal@kernel.org> · 2024-06-17
Re: [PATCH 13/26] block: move cache control settings out of queue->flags · Hannes Reinecke <hare@suse.de> · 2024-06-17
[PATCH 14/26] block: move the nonrot flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 14/26] block: move the nonrot flag to queue_limits · Hannes Reinecke <hare@suse.de> · 2024-06-17
Re: [PATCH 14/26] block: move the nonrot flag to queue_limits · Keith Busch <kbusch@kernel.org> · 2024-06-24
Re: [PATCH 14/26] block: move the nonrot flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-24
Re: [PATCH 14/26] block: move the nonrot flag to queue_limits · Simon Fernandez <hidden> · 2024-07-04
Re: [PATCH 14/26] block: move the nonrot flag to queue_limits · Wouter Verhelst <hidden> · 2024-07-25
Re: [PATCH 14/26] block: move the nonrot flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-07-25
[PATCH 15/26] block: move the add_random flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 15/26] block: move the add_random flag to queue_limits · Hannes Reinecke <hare@suse.de> · 2024-06-17
[PATCH 16/26] block: move the io_stat flag setting to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 16/26] block: move the io_stat flag setting to queue_limits · Damien Le Moal <dlemoal@kernel.org> · 2024-06-17
Re: [PATCH 16/26] block: move the io_stat flag setting to queue_limits · Hannes Reinecke <hare@suse.de> · 2024-06-17
[PATCH 19/26] block: move the nowait flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 19/26] block: move the nowait flag to queue_limits · Damien Le Moal <dlemoal@kernel.org> · 2024-06-17
Re: [PATCH 19/26] block: move the nowait flag to queue_limits · Hannes Reinecke <hare@suse.de> · 2024-06-17
[PATCH 18/26] block: move the synchronous flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 18/26] block: move the synchronous flag to queue_limits · Hannes Reinecke <hare@suse.de> · 2024-06-17
[PATCH 17/26] block: move the stable_writes flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 17/26] block: move the stable_writes flag to queue_limits · Hannes Reinecke <hare@suse.de> · 2024-06-17
[PATCH 20/26] block: move the dax flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 20/26] block: move the dax flag to queue_limits · Hannes Reinecke <hare@suse.de> · 2024-06-17
[PATCH 21/26] block: move the poll flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 21/26] block: move the poll flag to queue_limits · Hannes Reinecke <hare@suse.de> · 2024-06-17
[PATCH 22/26] block: move the zoned flag into the features field · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 22/26] block: move the zoned flag into the features field · Hannes Reinecke <hare@suse.de> · 2024-06-17
[PATCH 23/26] block: move the zone_resetall flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 23/26] block: move the zone_resetall flag to queue_limits · Hannes Reinecke <hare@suse.de> · 2024-06-17
[PATCH 24/26] block: move the pci_p2pdma flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 24/26] block: move the pci_p2pdma flag to queue_limits · Hannes Reinecke <hare@suse.de> · 2024-06-17
[PATCH 25/26] block: move the skip_tagset_quiesce flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 25/26] block: move the skip_tagset_quiesce flag to queue_limits · Hannes Reinecke <hare@suse.de> · 2024-06-17
[PATCH 26/26] block: move the bounce flag into the features field · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 26/26] block: move the bounce flag into the features field · Hannes Reinecke <hare@suse.de> · 2024-06-17
Re: [PATCH 26/26] block: move the bounce flag into the features field · Keith Busch <kbusch@kernel.org> · 2024-06-17
Re: move features flags into queue_limits v2 · Jens Axboe <axboe@kernel.dk> · 2024-06-19
Re: move features flags into queue_limits v2 · Jens Axboe <axboe@kernel.dk> · 2024-06-19
Re: move features flags into queue_limits v2 · Christoph Hellwig <hch@lst.de> · 2024-06-19

From: Keith Busch <kbusch@kernel.org>
Date: 2024-06-24 17:08:23
Also in: ceph-devel, dm-devel, linux-bcache, linux-block, linux-m68k, linux-mmc, linux-nvme, linux-raid, linux-s390, linux-scsi, linux-um, nvdimm, virtualization, xen-devel

On Mon, Jun 17, 2024 at 08:04:41AM +0200, Christoph Hellwig wrote:

-#define blk_queue_nonrot(q)	test_bit(QUEUE_FLAG_NONROT, &(q)->queue_flags)
+#define blk_queue_nonrot(q)	((q)->limits.features & BLK_FEAT_ROTATIONAL)

This is inverted. Should be:

 #define blk_queue_nonrot(q)	(!((q)->limits.features & BLK_FEAT_ROTATIONAL))

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help