Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics
From: Christoph Hellwig <hch@lst.de>
Date: 2024-06-17 04:54:02
Also in:
ceph-devel, dm-devel, linux-bcache, linux-block, linux-m68k, linux-mmc, linux-nvme, linux-raid, linux-s390, linux-scsi, linux-um, nvdimm, virtualization, xen-devel
On Mon, Jun 17, 2024 at 08:01:04AM +0900, Damien Le Moal wrote:
On 6/13/24 18:39, Christoph Hellwig wrote:quoted
On Tue, Jun 11, 2024 at 02:51:24PM +0900, Damien Le Moal wrote:quoted
quoted
+ if (sdkp->device->type == TYPE_ZBC)Nit: use sd_is_zoned() here ?Actually - is there much in even keeping sd_is_zoned now that the host aware support is removed? Just open coding the type check isn't any more code, and probably easier to follow.Removing this helper is fine by me.
FYI, I've removed it yesterday, but not done much of the cleanups suggest here. We should probably do those in a follow up up, uncluding removing the !ZBC check in sd_zbc_check_zoned_characteristics.