Re: [PATCH 10/26] xen-blkfront: don't disable cache flushes when they fail

move features flags into queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-11
[PATCH 01/26] sd: fix sd_is_zoned · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 01/26] sd: fix sd_is_zoned · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
Re: [PATCH 01/26] sd: fix sd_is_zoned · Hannes Reinecke <hare@suse.de> · 2024-06-11
Re: [PATCH 01/26] sd: fix sd_is_zoned · Johannes Thumshirn <hidden> · 2024-06-11
Re: [PATCH 01/26] sd: fix sd_is_zoned · Bart Van Assche <bvanassche@acm.org> · 2024-06-11
[PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics · Christoph Hellwig <hch@lst.de> · 2024-06-12
Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics · Christoph Hellwig <hch@lst.de> · 2024-06-13
Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics · Damien Le Moal <dlemoal@kernel.org> · 2024-06-16
Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics · Christoph Hellwig <hch@lst.de> · 2024-06-17
Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics · Damien Le Moal <dlemoal@kernel.org> · 2024-06-17
Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics · Hannes Reinecke <hare@suse.de> · 2024-06-11
[PATCH 03/26] loop: stop using loop_reconfigure_limits in __loop_clr_fd · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 03/26] loop: stop using loop_reconfigure_limits in __loop_clr_fd · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
Re: [PATCH 03/26] loop: stop using loop_reconfigure_limits in __loop_clr_fd · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 03/26] loop: stop using loop_reconfigure_limits in __loop_clr_fd · Hannes Reinecke <hare@suse.de> · 2024-06-11
Re: [PATCH 03/26] loop: stop using loop_reconfigure_limits in __loop_clr_fd · Bart Van Assche <bvanassche@acm.org> · 2024-06-11
[PATCH 04/26] loop: always update discard settings in loop_reconfigure_limits · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 04/26] loop: always update discard settings in loop_reconfigure_limits · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
Re: [PATCH 04/26] loop: always update discard settings in loop_reconfigure_limits · Hannes Reinecke <hare@suse.de> · 2024-06-11
Re: [PATCH 04/26] loop: always update discard settings in loop_reconfigure_limits · Bart Van Assche <bvanassche@acm.org> · 2024-06-11
[PATCH 05/26] loop: regularize upgrading the lock size for direct I/O · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 05/26] loop: regularize upgrading the lock size for direct I/O · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
Re: [PATCH 05/26] loop: regularize upgrading the lock size for direct I/O · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 05/26] loop: regularize upgrading the lock size for direct I/O · Hannes Reinecke <hare@suse.de> · 2024-06-11
Re: [PATCH 05/26] loop: regularize upgrading the lock size for direct I/O · Bart Van Assche <bvanassche@acm.org> · 2024-06-11
[PATCH 06/26] loop: also use the default block size from an underlying block device · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 06/26] loop: also use the default block size from an underlying block device · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
Re: [PATCH 06/26] loop: also use the default block size from an underlying block device · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 06/26] loop: also use the default block size from an underlying block device · Hannes Reinecke <hare@suse.de> · 2024-06-11
Re: [PATCH 06/26] loop: also use the default block size from an underlying block device · Bart Van Assche <bvanassche@acm.org> · 2024-06-11
[PATCH 07/26] loop: fold loop_update_rotational into loop_reconfigure_limits · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 07/26] loop: fold loop_update_rotational into loop_reconfigure_limits · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
Re: [PATCH 07/26] loop: fold loop_update_rotational into loop_reconfigure_limits · Hannes Reinecke <hare@suse.de> · 2024-06-11
Re: [PATCH 07/26] loop: fold loop_update_rotational into loop_reconfigure_limits · Bart Van Assche <bvanassche@acm.org> · 2024-06-11
[PATCH 08/26] virtio_blk: remove virtblk_update_cache_mode · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 08/26] virtio_blk: remove virtblk_update_cache_mode · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
Re: [PATCH 08/26] virtio_blk: remove virtblk_update_cache_mode · Hannes Reinecke <hare@suse.de> · 2024-06-11
Re: [PATCH 08/26] virtio_blk: remove virtblk_update_cache_mode · Johannes Thumshirn <hidden> · 2024-06-11
Re: [PATCH 08/26] virtio_blk: remove virtblk_update_cache_mode · Stefan Hajnoczi <stefanha@redhat.com> · 2024-06-11
Re: [PATCH 08/26] virtio_blk: remove virtblk_update_cache_mode · Bart Van Assche <bvanassche@acm.org> · 2024-06-11
[PATCH 09/26] nbd: move setting the cache control flags to __nbd_set_size · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 09/26] nbd: move setting the cache control flags to __nbd_set_size · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
Re: [PATCH 09/26] nbd: move setting the cache control flags to __nbd_set_size · Hannes Reinecke <hare@suse.de> · 2024-06-11
Re: [PATCH 09/26] nbd: move setting the cache control flags to __nbd_set_size · Josef Bacik <josef@toxicpanda.com> · 2024-06-11
Re: [PATCH 09/26] nbd: move setting the cache control flags to __nbd_set_size · Bart Van Assche <bvanassche@acm.org> · 2024-06-11
[PATCH 10/26] xen-blkfront: don't disable cache flushes when they fail · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 10/26] xen-blkfront: don't disable cache flushes when they fail · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
Re: [PATCH 10/26] xen-blkfront: don't disable cache flushes when they fail · Christoph Hellwig <hch@lst.de> · 2024-06-12
Re: [PATCH 10/26] xen-blkfront: don't disable cache flushes when they fail · Hannes Reinecke <hare@suse.de> · 2024-06-11
Re: [PATCH 10/26] xen-blkfront: don't disable cache flushes when they fail · Roger Pau Monné <roger.pau@citrix.com> · 2024-06-12
Re: [PATCH 10/26] xen-blkfront: don't disable cache flushes when they fail · Christoph Hellwig <hch@lst.de> · 2024-06-12
Re: [PATCH 10/26] xen-blkfront: don't disable cache flushes when they fail · Roger Pau Monné <roger.pau@citrix.com> · 2024-06-12
Re: [PATCH 10/26] xen-blkfront: don't disable cache flushes when they fail · Christoph Hellwig <hch@lst.de> · 2024-06-13
Re: [PATCH 10/26] xen-blkfront: don't disable cache flushes when they fail · Roger Pau Monné <roger.pau@citrix.com> · 2024-06-14
[PATCH 11/26] block: freeze the queue in queue_attr_store · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 11/26] block: freeze the queue in queue_attr_store · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
Re: [PATCH 11/26] block: freeze the queue in queue_attr_store · Hannes Reinecke <hare@suse.de> · 2024-06-11
Re: [PATCH 11/26] block: freeze the queue in queue_attr_store · Bart Van Assche <bvanassche@acm.org> · 2024-06-11
[PATCH 12/26] block: remove blk_flush_policy · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 12/26] block: remove blk_flush_policy · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
Re: [PATCH 12/26] block: remove blk_flush_policy · Hannes Reinecke <hare@suse.de> · 2024-06-11
Re: [PATCH 12/26] block: remove blk_flush_policy · Bart Van Assche <bvanassche@acm.org> · 2024-06-11
[PATCH 13/26] block: move cache control settings out of queue->flags · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 13/26] block: move cache control settings out of queue->flags · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
Re: [PATCH 13/26] block: move cache control settings out of queue->flags · Christoph Hellwig <hch@lst.de> · 2024-06-12
Re: [PATCH 13/26] block: move cache control settings out of queue->flags · Hannes Reinecke <hare@suse.de> · 2024-06-11
Re: [PATCH 13/26] block: move cache control settings out of queue->flags · Christoph Hellwig <hch@lst.de> · 2024-06-12
Re: [PATCH 13/26] block: move cache control settings out of queue->flags · Ulf Hansson <hidden> · 2024-06-12
[PATCH 14/26] block: move the nonrot flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 14/26] block: move the nonrot flag to queue_limits · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
[PATCH 15/26] block: move the add_random flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 15/26] block: move the add_random flag to queue_limits · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
[PATCH 16/26] block: move the io_stat flag setting to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 16/26] block: move the io_stat flag setting to queue_limits · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
Re: [PATCH 16/26] block: move the io_stat flag setting to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-12
[PATCH 17/26] block: move the stable_write flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 17/26] block: move the stable_write flag to queue_limits · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
[PATCH 18/26] block: move the synchronous flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 18/26] block: move the synchronous flag to queue_limits · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
[PATCH 19/26] block: move the nowait flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 19/26] block: move the nowait flag to queue_limits · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
Re: [PATCH 19/26] block: move the nowait flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-12
[PATCH 20/26] block: move the dax flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 20/26] block: move the dax flag to queue_limits · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
[PATCH 21/26] block: move the poll flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 21/26] block: move the poll flag to queue_limits · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
Re: [PATCH 21/26] block: move the poll flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-12
[PATCH 22/26] block: move the zoned flag into the feature field · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 22/26] block: move the zoned flag into the feature field · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
[PATCH 23/26] block: move the zone_resetall flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 23/26] block: move the zone_resetall flag to queue_limits · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
[PATCH 25/26] block: move the skip_tagset_quiesce flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 25/26] block: move the skip_tagset_quiesce flag to queue_limits · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
[PATCH 24/26] block: move the pci_p2pdma flag to queue_limits · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 24/26] block: move the pci_p2pdma flag to queue_limits · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11
[PATCH 26/26] block: move the bounce flag into the feature field · Christoph Hellwig <hch@lst.de> · 2024-06-11
Re: [PATCH 26/26] block: move the bounce flag into the feature field · Damien Le Moal <dlemoal@kernel.org> · 2024-06-11

From: Christoph Hellwig <hch@lst.de>
Date: 2024-06-12 04:50:32
Also in: ceph-devel, dm-devel, linux-bcache, linux-block, linux-m68k, linux-mmc, linux-nvme, linux-raid, linux-s390, linux-scsi, linux-um, nvdimm, virtualization, xen-devel

On Tue, Jun 11, 2024 at 04:30:39PM +0900, Damien Le Moal wrote:

On 6/11/24 2:19 PM, Christoph Hellwig wrote:

quoted

blkfront always had a robust negotiation protocol for detecting a write
cache.  Stop simply disabling cache flushes when they fail as that is
a grave error.

Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good to me but maybe mention that removal of xlvbd_flush() as well ?
And it feels like the "stop disabling cache flushes when they fail" part should
be a fix patch sent separately...

I'll move the patch to the front of the series to get more attention from
the maintainers, but otherwise the xlvbd_flush remova lis the really
trivial part here.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help