Thread (12 messages) 12 messages, 5 authors, 2024-07-01

Re: [PATCH 0/2] Skip offline cores when enabling SMT on PowerPC

From: Thomas Gleixner <hidden>
Date: 2024-06-24 21:24:13
Also in: lkml

On Tue, Jun 25 2024 at 00:41, Shrikanth Hegde wrote:
On 6/24/24 1:44 AM, Thomas Gleixner wrote:
quoted
Right. So changing it not to online a thread when the full core is
offline should not really break stuff.

OTH, the mechanism to figure that out on x86 is definitely different and
more complicated than on power because the sibling threads are not
having consecutive CPU numbers.
wouldn't topology_sibling_cpumask have this info? 
If the mask is empty does it mean the core is offline? 
The mask is not yet available for the to be brought up CPU. That's
established when the CPU boots. It might work because all threads are
brought up during early boot for !~*&^!@% reasons, but then it won't
work under all circumstances, e.g. 'maxcpus=$N'.

We could fix that now with the new topology enumeration code, but that's
a larger scale project.

Thanks,

        tglx
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help