Re: [PATCH v4 5/5] net: wan: fsl_qmc_hdlc: Add framer support
From: Herve Codina <herve.codina@bootlin.com>
Date: 2024-02-29 14:15:12
Also in:
lkml, netdev
On Thu, 29 Feb 2024 15:58:06 +0200 Andy Shevchenko [off-list ref] wrote:
On Thu, Feb 29, 2024 at 01:56:05PM +0100, Herve Codina wrote:quoted
On Thu, 22 Feb 2024 17:49:40 +0200 Andy Shevchenko [off-list ref] wrote:quoted
On Thu, Feb 22, 2024 at 03:22:18PM +0100, Herve Codina wrote:...quoted
I've got an issue with guard(spinlock_irqsave).No, you got an issue with sparse.quoted
I have the following warning (make C=1): drivers/net/wan/fsl_qmc_hdlc.c:49:12: warning: context imbalance in 'qmc_hdlc_framer_set_carrier' - wrong count at exit I also tried to call guard(spinlock_irqsave) before 'if (!qmc_hdlc->framer)' but it does not change anything. Did I miss something in the guard(spinlock_irqsave) usage ?You may ignore that for now. Not your problem, no problem in the code. https://lore.kernel.org/linux-sparse/8d596a06-9f25-4d9f-8282-deb2d03a6b0a@moroto.mountain/
Perfect, thanks. Hervé