Thread (22 messages) 22 messages, 3 authors, 2024-02-29

Re: [PATCH v4 3/5] lib/bitmap: Introduce bitmap_scatter() and bitmap_gather() helpers

From: Herve Codina <herve.codina@bootlin.com>
Date: 2024-02-23 10:08:04
Also in: lkml, netdev

Andy, Yury,

On Thu, 22 Feb 2024 13:50:48 -0800
Yury Norov [off-list ref] wrote:
On Thu, Feb 22, 2024 at 05:49:59PM +0100, Herve Codina wrote:
quoted
Hi Andy, Yury,

On Thu, 22 Feb 2024 17:39:27 +0200
Andy Shevchenko [off-list ref] wrote:

...  
quoted
quoted
+ * bitmap_scatter() for the bitmap scatter detailed operations).    
  
quoted
+ * Suppose scattered computed using bitmap_scatter(scattered, src, mask, n).
+ * The operation bitmap_gather(result, scattered, mask, n) leads to a result
+ * equal or equivalent to src.    
This paragraph...
  
quoted
+ * The result can be 'equivalent' because bitmap_scatter() and bitmap_gather()
+ * are not bijective.    
  
quoted
+ * The result and src values are equivalent in that sense that a call to
+ * bitmap_scatter(res, src, mask, n) and a call to bitmap_scatter(res, result,
+ * mask, n) will lead to the same res value.    
...seems duplicating this one.

I would drop the latter one.  
I would like to give details about the 'equivalent' in this scatter/gather case.  
If you would like - please do! :)
 
quoted
If Yury is ok, I can drop this last paragraph.  
The original bitmap_onto() description is 3 times longer, and barely
that descriptive. I'm OK with your working and especially pictures.
Right, I will keep my last paragraph in the next iteration.

Regards,
Hervé

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help