Re: [PATCH V4] tools/perf: Add perf binary dependent rule for shellcheck log in Makefile.perf

Em Wed, Dec 06, 2023 at 10:15:06AM +0530, Athira Rajeev escreveu:

quoted

On 06-Dec-2023, at 3:20 AM, Arnaldo Carvalho de Melo [off-list ref] wrote:

Em Mon, Nov 27, 2023 at 11:12:57AM +0000, James Clark escreveu:

quoted

On 23/11/2023 16:02, Athira Rajeev wrote:

quoted

--- a/tools/perf/Makefile.perf

@@ -1134,6 +1152,7 @@ bpf-skel-clean:

$(call QUIET_CLEAN, bpf-skel) $(RM) -r $(SKEL_TMP_OUT) $(SKELETONS)

clean:: $(LIBAPI)-clean $(LIBBPF)-clean $(LIBSUBCMD)-clean $(LIBSYMBOL)-clean $(LIBPERF)-clean fixdep-clean python-clean bpf-skel-clean tests-coresight-targets-clean
+ $(Q)$(MAKE) -f $(srctree)/tools/perf/tests/Makefile.tests clean
$(call QUIET_CLEAN, core-objs)  $(RM) $(LIBPERF_A) $(OUTPUT)perf-archive $(OUTPUT)perf-iostat $(LANG_BINDINGS)
$(Q)find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.cmd' -delete -o -name '\.*.d' -delete
$(Q)$(RM) $(OUTPUT).config-detected

While merging perf-tools-next with torvalds/master I noticed that maybe
we better have the above added line as:

+   $(call QUIET_CLEAN, tests) $(Q)$(MAKE) -f $(srctree)/tools/perf/tests/Makefile.tests clean

No?

Anyway I'm merging as-is, but it just hit my eye while merging,

- Arnaldo

Hi Arnaldo

As Ian pointed we removed Makefile.tests as part of :
https://lore.kernel.org/lkml/20231129213428.2227448-1-irogers@google.com/ (local)

Right, thanks for checking, see my reply to Ian for further details.

- Arnaldo