On 27-Nov-2023, at 8:21 PM, Arnaldo Carvalho de Melo [off-list ref] wrote:

Em Mon, Nov 27, 2023 at 11:12:57AM +0000, James Clark escreveu:

quoted

On 23/11/2023 16:02, Athira Rajeev wrote:

quoted

Add rule in new Makefile "tests/Makefile.tests" for running
shellcheck on shell test scripts. This automates below shellcheck
into the build.

quoted

Seems to work really well. I also tested it on Ubuntu, and checked
NO_SHELLCHECK, cleaning and with and without shellcheck installed etc.

quoted

Reviewed-by: James Clark <redacted>

Tested on Fedora 38, works as advertised, applied.

- Arnaldo

Hi James, Arnaldo

Thanks for testing the patch and comments.

Athira Rajeev