Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block()

[PATCH v4 00/12] KVM: x86: never write to memory from kvm_vcpu_check_block · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 01/12] KVM: x86: make vendor code check for all nested events · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 02/12] KVM: nVMX: Make an event request when pending an MTF nested VM-Exit · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 03/12] KVM: x86: Rename and expose helper to detect if INIT/SIPI are allowed · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 04/12] KVM: x86: Rename kvm_apic_has_events() to make it INIT/SIPI specific · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 05/12] KVM: x86: lapic does not have to process INIT if it is blocked · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 06/12] KVM: SVM: Make an event request if INIT or SIPI is pending when GIF is set · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 07/12] KVM: nVMX: Make an event request if INIT or SIPI is pending on VM-Enter · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 09/12] KVM: x86: Don't snapshot pending INIT/SIPI prior to checking nested events · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 08/12] KVM: nVMX: Make event request on VMXOFF iff INIT/SIPI is pending · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() · Jim Mattson <hidden> · 2023-12-07
Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() · Sean Christopherson <seanjc@google.com> · 2023-12-07
Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() · Jim Mattson <hidden> · 2023-12-10
Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() · Sean Christopherson <seanjc@google.com> · 2023-12-12
Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() · Maxim Levitsky <hidden> · 2023-12-13
Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() · Jim Mattson <hidden> · 2023-12-13
Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() · Maxim Levitsky <hidden> · 2023-12-13
Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() · Sean Christopherson <seanjc@google.com> · 2023-12-13
[PATCH v4 11/12] KVM: mips, x86: do not rely on KVM_REQ_UNHALT · Sean Christopherson <seanjc@google.com> · 2022-09-21
Re: [PATCH v4 11/12] KVM: mips, x86: do not rely on KVM_REQ_UNHALT · Philippe Mathieu-Daudé <hidden> · 2022-09-22
[PATCH v4 12/12] KVM: remove KVM_REQ_UNHALT · Sean Christopherson <seanjc@google.com> · 2022-09-21
Re: [PATCH v4 12/12] KVM: remove KVM_REQ_UNHALT · Marc Zyngier <maz@kernel.org> · 2022-09-22

From: Sean Christopherson <seanjc@google.com>
Date: 2023-12-12 15:29:52
Also in: kvm, kvm-riscv, linux-arm-kernel, linux-mips, linux-riscv, lkml

On Sun, Dec 10, 2023, Jim Mattson wrote:

On Thu, Dec 7, 2023 at 8:21 AM Sean Christopherson [off-list ref] wrote:

quoted

Doh.  We got the less obvious cases and missed the obvious one.

Ugh, and we also missed a related mess in kvm_guest_apic_has_interrupt().  That
thing should really be folded into vmx_has_nested_events().

Good gravy.  And vmx_interrupt_blocked() does the wrong thing because that
specifically checks if L1 interrupts are blocked.

Compile tested only, and definitely needs to be chunked into multiple patches,
but I think something like this mess?

The proposed patch does not fix the problem. In fact, it messes things
up so much that I don't get any test results back.

Drat.

Google has an internal K-U-T test that demonstrates the problem. I
will post it soon.

Received, I'll dig in soonish, though "soonish" might unfortunately might mean
2024.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help