Re: [PATCH v4 11/12] KVM: mips, x86: do not rely on KVM_REQ_UNHALT

[PATCH v4 00/12] KVM: x86: never write to memory from kvm_vcpu_check_block · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 01/12] KVM: x86: make vendor code check for all nested events · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 02/12] KVM: nVMX: Make an event request when pending an MTF nested VM-Exit · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 03/12] KVM: x86: Rename and expose helper to detect if INIT/SIPI are allowed · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 04/12] KVM: x86: Rename kvm_apic_has_events() to make it INIT/SIPI specific · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 05/12] KVM: x86: lapic does not have to process INIT if it is blocked · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 06/12] KVM: SVM: Make an event request if INIT or SIPI is pending when GIF is set · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 07/12] KVM: nVMX: Make an event request if INIT or SIPI is pending on VM-Enter · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 09/12] KVM: x86: Don't snapshot pending INIT/SIPI prior to checking nested events · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 08/12] KVM: nVMX: Make event request on VMXOFF iff INIT/SIPI is pending · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() · Sean Christopherson <seanjc@google.com> · 2022-09-21
[PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() · Jim Mattson <hidden> · 2023-12-07
Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() · Sean Christopherson <seanjc@google.com> · 2023-12-07
Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() · Jim Mattson <hidden> · 2023-12-10
Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() · Sean Christopherson <seanjc@google.com> · 2023-12-12
Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() · Maxim Levitsky <hidden> · 2023-12-13
Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() · Jim Mattson <hidden> · 2023-12-13
Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() · Maxim Levitsky <hidden> · 2023-12-13
Re: [PATCH v4 10/12] KVM: x86: never write to memory from kvm_vcpu_check_block() · Sean Christopherson <seanjc@google.com> · 2023-12-13
[PATCH v4 11/12] KVM: mips, x86: do not rely on KVM_REQ_UNHALT · Sean Christopherson <seanjc@google.com> · 2022-09-21
Re: [PATCH v4 11/12] KVM: mips, x86: do not rely on KVM_REQ_UNHALT · Philippe Mathieu-Daudé <hidden> · 2022-09-22
[PATCH v4 12/12] KVM: remove KVM_REQ_UNHALT · Sean Christopherson <seanjc@google.com> · 2022-09-21
Re: [PATCH v4 12/12] KVM: remove KVM_REQ_UNHALT · Marc Zyngier <maz@kernel.org> · 2022-09-22

From: Philippe Mathieu-Daudé <hidden>
Date: 2022-09-22 13:18:29
Also in: kvm, kvm-riscv, kvmarm, linux-arm-kernel, linux-mips, linux-riscv, lkml

On Wed, Sep 21, 2022 at 2:34 AM Sean Christopherson [off-list ref] wrote:

From: Paolo Bonzini <pbonzini@redhat.com>

KVM_REQ_UNHALT is a weird request that simply reports the value of
kvm_arch_vcpu_runnable() on exit from kvm_vcpu_halt().  Only
MIPS and x86 are looking at it, the others just clear it.  Check
the state of the vCPU directly so that the request is handled
as a nop on all architectures.

No functional change intended, except for corner cases where an
event arrive immediately after a signal become pending or after
another similar host-side event.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
 arch/mips/kvm/emulate.c | 7 +++----
 arch/x86/kvm/x86.c      | 9 ++++++++-
 2 files changed, 11 insertions(+), 5 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <redacted>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help