Thread (43 messages) 43 messages, 17 authors, 2024-01-10

Re: [PATCH 16/22] bcachefs: mark bch2_target_to_text_sb() static

From: Kent Overstreet <kent.overstreet@linux.dev>
Date: 2023-11-08 20:19:48
Also in: linux-alpha, linux-bcachefs, linux-fbdev, linux-kbuild, linux-m68k, linux-mips, linux-riscv, linux-s390, linux-sh, linux-trace-kernel, linux-usb, lkml, loongarch, netdev, sparclinux

On Wed, Nov 08, 2023 at 01:58:37PM +0100, Arnd Bergmann wrote:
From: Arnd Bergmann <arnd@arndb.de>

bch2_target_to_text_sb() is only called in the file it is defined in,
and it has no extern prototype:

fs/bcachefs/disk_groups.c:583:6: error: no previous prototype for 'bch2_target_to_text_sb' [-Werror=missing-prototypes]

Mark it static to avoid the warning and have the code better optimized.

Fixes: bf0d9e89de2e ("bcachefs: Split apart bch2_target_to_text(), bch2_target_to_text_sb()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This is already fixed in my tree.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help