Re: [PATCH 15/22] arch: vdso: consolidate gettime prototypes
From: "Arnd Bergmann" <arnd@arndb.de>
Date: 2023-11-08 19:37:39
Also in:
dri-devel, linux-alpha, linux-bcachefs, linux-fbdev, linux-kbuild, linux-m68k, linux-mips, linux-riscv, linux-s390, linux-sh, linux-trace-kernel, linux-usb, lkml, loongarch, netdev, sparclinux
On Wed, Nov 8, 2023, at 19:31, Christophe Leroy wrote:
Le 08/11/2023 à 13:58, Arnd Bergmann a écrit :
powerpc has functions doing more or less the same, they are called __c_kernel_clock_gettime() and alike with their prototypes siting in arch/powerpc/include/asm/vdso/gettimeofday.h Should those prototypes be moved to include/vdso/gettime.h too and eventually renamed, or are they considered too powerpc specific ?
I don't actually know, my initial interpretation was that
these function names are part of the user ABI for the vdso,
but I never looked closely enough at how vdso works to
be sure what the actual ABI is.
If __c_kernel_clock_gettime() etc are not part of the user-facing
ABI, I think renaming them for consistency with the other
architectures would be best.
Arnd