Re: [PATCH v2 10/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*

From
Herve Codina <herve.codina@bootlin.com>
Date
2023-08-01 10:27:15
Also in
alsa-devel, linux-arm-kernel, linux-devicetree, linux-gpio, lkml, netdev
Reply to
Andrew Lunn, 2023-08-01
On Tue, 1 Aug 2023 11:36:43 +0200
Andrew Lunn [off-list ref] wrote:
quoted
+static inline void qmc_clrsetbits16(void __iomem *addr, u16 clr, u16 set)
+{
+	qmc_write16(addr, (qmc_read16(addr) & ~clr) | set);
+}
+  
Please don't use inline in .c files. Let the compiler decide.

       Andrew
Ok, I will remove the inline in the next iteration.
I will also remove the inline of all other similar functions (probably a
separate patch in the series).

Regards,
Hervé
Thread (91 messages) 91 messages, 8 authors, last reply 2023-08-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help