Re: [PATCH v2 10/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*
From: Herve Codina <herve.codina@bootlin.com>
Date: 2023-08-01 10:27:15
Also in:
alsa-devel, linux-devicetree, linux-gpio, linuxppc-dev, lkml, netdev
On Tue, 1 Aug 2023 11:36:43 +0200 Andrew Lunn [off-list ref] wrote:
quoted
+static inline void qmc_clrsetbits16(void __iomem *addr, u16 clr, u16 set) +{ + qmc_write16(addr, (qmc_read16(addr) & ~clr) | set); +} +Please don't use inline in .c files. Let the compiler decide. Andrew
Ok, I will remove the inline in the next iteration. I will also remove the inline of all other similar functions (probably a separate patch in the series). Regards, Hervé _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel