-----Original Message-----
From: Azeem Shaikh <redacted>
Sent: Sunday, July 9, 2023 9:36 PM
To: Kees Cook <redacted>
Cc: Qiang Zhao <qiang.zhao@nxp.com>; linux-hardening@vger.kernel.org;
linuxppc-dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; Leo Li
[off-list ref]; linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] soc: fsl: qe: Replace all non-returning strlcpy with
strscpy

On Tue, May 23, 2023 at 1:20 PM Kees Cook [off-list ref]
wrote:

quoted

On Tue, May 23, 2023 at 02:14:25AM +0000, Azeem Shaikh wrote:

quoted

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read overflows if a
source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1]

https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww

quoted

quoted

w.kernel.org%2Fdoc%2Fhtml%2Flatest%2Fprocess%2Fdeprecated.html%23s
tr

quoted

quoted

lcpy&data=05%7C01%7Cleoyang.li%40nxp.com%7C11f9df1df1b5440e4ec108
db8

quoted

quoted

0ee64de%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63824553360
3780

quoted

quoted

889%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2lu
MzIiLCJB

quoted

quoted

TiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=jcTy3IF37wqC1
MWsSuF

quoted

quoted

%2F51Z1trQEMaow7BHkPSh3hzI%3D&reserved=0
[2]
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi

thub.com%2FKSPP%2Flinux%2Fissues%2F89&data=05%7C01%7Cleoyang.li%
40nx

quoted

quoted

p.com%7C11f9df1df1b5440e4ec108db80ee64de%7C686ea1d3bc2b4c6fa92cd
99c5

quoted

quoted

c301635%7C0%7C0%7C638245533603780889%7CUnknown%7CTWFpbGZsb3d
8eyJWIjo

quoted

quoted

iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C30
00%7

quoted

quoted

C%7C%7C&sdata=Blr0W1oYPIw5uDu7HqlEkU7xOuAo4bQNkk%2Bt%2BAuFqc
s%3D&res

quoted

quoted

erved=0

Signed-off-by: Azeem Shaikh <redacted>

Reviewed-by: Kees Cook <redacted>

Friendly ping on this.

Sorry for the late response.  But I found some old discussions with the conclusion to be not converting old users.  Has this been changed later on?
https://lwn.net/Articles/659214/

Regards,
Leo