Re: [PATCH] soc: fsl: qe: Replace all non-returning strlcpy with strscpy
From: Azeem Shaikh <hidden>
Date: 2023-07-10 02:36:02
Also in:
linux-arm-kernel, linux-hardening, lkml
On Tue, May 23, 2023 at 1:20 PM Kees Cook [off-list ref] wrote:
On Tue, May 23, 2023 at 02:14:25AM +0000, Azeem Shaikh wrote:quoted
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] https://github.com/KSPP/linux/issues/89 Signed-off-by: Azeem Shaikh <redacted>Reviewed-by: Kees Cook <redacted>
Friendly ping on this.