Re: [PATCH 2/4] powerpc/64s: Add POWER10 store sync mnemonics
From: "Nicholas Piggin" <npiggin@gmail.com>
Date: 2023-06-14 05:32:55
From: "Nicholas Piggin" <npiggin@gmail.com>
Date: 2023-06-14 05:32:55
On Tue Jun 13, 2023 at 3:31 PM AEST, Joel Stanley wrote:
On Fri, 9 Jun 2023 at 10:01, Nicholas Piggin [off-list ref] wrote:quoted
ISA v3.1 introduces new sync types for store ordering. stncisync stcisync stsync Add ppc-opcode defines for these. This changes PPC_RAW_SYNC to take L,SC parameters and adds a PPC_RAW_HWSYNC for callers that want the plain old sync (aka hwsync).I checked these against the ISA and they seem correct. Did you consider changing LWSYNC to be defined in terms of your new PPC_RAW_SYNC?
Oh I haven't but it would be consistent to change that wouldn't it?
Reviewed-by: Joel Stanley <joel@jms.id.au>.
Thanks, Nick