RE: [PATCH 0/6] bus: fsl-mc: Make remove function return void
From: Leo Li <hidden>
Date: 2023-05-31 00:01:37
Also in:
dmaengine, kvm, linux-arm-kernel, linux-crypto, lkml, netdev
-----Original Message----- From: Uwe Kleine-König <redacted> Sent: Tuesday, May 30, 2023 8:51 AM To: Leo Li <redacted> Cc: Stuart Yoder <redacted>; Gaurav Jain [off-list ref]; Roy Pledge [off-list ref]; Diana Madalina Craciun (OSS) [off-list ref]; Eric Dumazet [off-list ref]; Ioana Ciornei [off-list ref]; kvm@vger.kernel.org; Horia Geanta [off-list ref]; Jakub Kicinski [off-list ref]; Paolo Abeni [off-list ref]; Laurentiu Tudor [off-list ref]; Richard Cochran [off-list ref]; Pankaj Gupta [off-list ref]; Alex Williamson [off-list ref]; linux-arm- kernel@lists.infradead.org; Herbert Xu [off-list ref]; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Vinod Koul [off-list ref]; linux-crypto@vger.kernel.org; kernel@pengutronix.de; Y.B. Lu [off-list ref]; dmaengine@vger.kernel.org; linuxppc- dev@lists.ozlabs.org; David S. Miller [off-list ref] Subject: Re: [PATCH 0/6] bus: fsl-mc: Make remove function return void Hello, On Mon, May 08, 2023 at 04:57:00PM -0500, Li Yang wrote:quoted
On Mon, May 8, 2023 at 8:44 AM Uwe Kleine-König [off-list ref] wrote:quoted
On Thu, Apr 13, 2023 at 08:00:04AM +0200, Uwe Kleine-König wrote:quoted
On Wed, Apr 12, 2023 at 09:30:05PM +0000, Leo Li wrote:quoted
quoted
On Fri, Mar 10, 2023 at 11:41:22PM +0100, Uwe Kleine-König wrote:quoted
Hello, many bus remove functions return an integer which is a historic misdesign that makes driver authors assume that there is some kind of error handling in the upper layers. This is wrong however and returning and error code only yields anerror message.quoted
quoted
quoted
quoted
quoted
quoted
This series improves the fsl-mc bus by changing the remove callback to return no value instead. As a preparation all drivers are changed to return zero before so that they don'ttrigger the error message.quoted
quoted
quoted
quoted
quoted
Who is supposed to pick up this patch series (or point out a good reason for not taking it)?Previously Greg KH picked up MC bus patches. If no one is picking up them this time, I probably can take it through the fsl soc tree.I guess Greg won't pick up this series as he didn't get a copy of it :-) Browsing through the history of drivers/bus/fsl-mc there is no consistent maintainer to see. So if you can take it, that's very appreciated.My mail was meant encouraging, maybe it was too subtile? I'll try again: Yes, please apply, that would be wonderful!Sorry for missing your previous email. I will do that. Thanks.Either you didn't apply this patch set yet, or your tree isn't in next. Both variants would be great to be fixed. I have another change pending for drivers/bus/fsl-mc/fsl-mc-bus.c, would be great to see these base patches in next first.
I have applied them to the next branch of my tree. They will be part of the Linux-next soon. Regards, Leo