Thread (13 messages) 13 messages, 5 authors, 2023-05-31

Re: [PATCH 0/6] bus: fsl-mc: Make remove function return void

From: Ioana Ciornei <ioana.ciornei@nxp.com>
Date: 2023-03-13 13:46:48
Also in: dmaengine, kvm, linux-arm-kernel, linux-crypto, lkml, netdev

On Fri, Mar 10, 2023 at 11:41:22PM +0100, Uwe Kleine-König wrote:
Hello,

many bus remove functions return an integer which is a historic
misdesign that makes driver authors assume that there is some kind of
error handling in the upper layers. This is wrong however and returning
and error code only yields an error message.

This series improves the fsl-mc bus by changing the remove callback to
return no value instead. As a preparation all drivers are changed to
return zero before so that they don't trigger the error message.

Best regards
Uwe

Uwe Kleine-König (6):
  bus: fsl-mc: Only warn once about errors on device unbind
  bus: fsl-mc: dprc: Push down error message from fsl_mc_driver_remove()
  bus: fsl-mc: fsl-mc-allocator: Drop if block with always wrong
    condition
  bus: fsl-mc: fsl-mc-allocator: Improve error reporting
  soc: fsl: dpio: Suppress duplicated error reporting on device remove
  bus: fsl-mc: Make remove function return void
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Tested-by: Ioana Ciornei <ioana.ciornei@nxp.com> # sanity checks

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help