Re: [PATCH 01/10] watchdog/hardlockup: Keep kernel.nmi_watchdog sysctl as 0444 if probe fails

From
Petr Mladek <pmladek@suse.com>
Date
2023-05-30 14:16:11
Also in
linux-perf-users, lkml, sparclinux
Reply to
Douglas Anderson, 2023-05-27
On Fri 2023-05-26 18:41:31, Douglas Anderson wrote:
The permissions for the kernel.nmi_watchdog sysctl have always been
set at compile time despite the fact that a watchdog can fail to
probe. Let's fix this and set the permissions based on whether the
hardlockup detector actually probed.

Fixes: a994a3147e4c ("watchdog/hardlockup/perf: Implement init time detection of perf")
Reported-by: Petr Mladek <pmladek@suse.com>
Closes: https://lore.kernel.org/r/ZHCn4hNxFpY5-9Ki@alley (local)
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Looks good to me:

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr
Thread (21 messages) 21 messages, 2 authors, last reply 2023-06-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help