Re: [PATCH 2/2] powerpc/xmon: use KSYM_NAME_LEN in array size
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2023-05-30 06:45:54
Also in:
lkml
Maninder Singh [off-list ref] writes:
kallsyms_lookup which in turn calls for kallsyms_lookup_buildid()
writes on index "KSYM_NAME_LEN - 1".
Thus array size should be KSYM_NAME_LEN.
for powerpc it was defined as "128" directly.
and commit '61968dbc2d5d' changed define value to 512,
So both were missed to update with new size.
Fixes: 61968dbc2d5d ("kallsyms: increase maximum kernel symbol length to 512")
AFAICS that's the wrong sha.
That commit appears in linux-next, but the commit that actually went
into mainline is:
b8a94bfb3395 ("kallsyms: increase maximum kernel symbol length to 512")
So I'll update the change log to refer to that.
cheers
quoted hunk ↗ jump to hunk
Co-developed-by: Onkarnath <redacted> Signed-off-by: Onkarnath <redacted> Signed-off-by: Maninder Singh <redacted> --- arch/powerpc/xmon/xmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c index 728d3c257e4a..70c4c59a1a8f 100644 --- a/arch/powerpc/xmon/xmon.c +++ b/arch/powerpc/xmon/xmon.c@@ -88,7 +88,7 @@ static unsigned long ndump = 64; static unsigned long nidump = 16; static unsigned long ncsum = 4096; static int termch; -static char tmpstr[128]; +static char tmpstr[KSYM_NAME_LEN]; static int tracing_enabled; static long bus_error_jmp[JMP_BUF_LEN];-- 2.17.1