Thread (12 messages) 12 messages, 7 authors, 2023-08-03

Re: [PATCH 2/2] powerpc/xmon: use KSYM_NAME_LEN in array size

From: Miguel Ojeda <hidden>
Date: 2023-05-30 12:56:08
Also in: lkml

On Mon, May 29, 2023 at 1:14 PM Maninder Singh [off-list ref] wrote:
+static char tmpstr[KSYM_NAME_LEN];
Reviewed-by: Miguel Ojeda <ojeda@kernel.org>

Side-note: in `get_function_bounds()`, I see `kallsyms_lookup()` being
used, but the name seems discarded? Can
`kallsyms_lookup_size_offset()` be used instead, thus avoiding the
usage of the buffer there to begin with?

Side-note 2: in `scanhex()`, I see a loop `i<63` using `tmpstr` which
then is used to do a `kallsyms_lookup_name()`, so I guess symbols
larger than 64 couldn't be found. I have no idea about what are the
external constraints here, but perhaps it is possible to increase the
`line` buffer etc. to then allow for bigger symbols to be found.

Cheers,
Miguel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help