Thread (32 messages) 32 messages, 6 authors, 2024-01-25

Re: [PATCH 6/8] powerpc/rtas: lockdep annotations

From: Andrew Donnellan <hidden>
Date: 2023-03-23 06:03:05

On Mon, 2023-03-06 at 15:33 -0600, Nathan Lynch via B4 Relay wrote:
From: Nathan Lynch <redacted>

Add lockdep annotations for the following properties that must hold:

* Any error log retrieval must be atomically coupled with the prior
  RTAS call, without a window for another RTAS call to occur before
the
  error log can be retrieved.

* All users of the core rtas_args parameter block must hold
rtas_lock.

Move the definitions of rtas_lock and rtas_args up in the file so
that
__do_enter_rtas_trace() can refer to them.

Signed-off-by: Nathan Lynch <redacted>
I'm no lockdep expert and I haven't checked if every possible case that
can be annotated has been annotated, but these changes make sense as
far as I can tell from my limited inspection.

Reviewed-by: Andrew Donnellan <redacted>

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@linux.ibm.com   IBM Australia Limited
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help