Re: [PATCH v7 4/6] EISA: Convert to use less arguments in pci_bus_for_each_resource()
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2023-03-24 09:20:16
Also in:
linux-acpi, linux-alpha, linux-arm-kernel, linux-mips, linux-pci, linux-sh, lkml, sparclinux, xen-devel
On Fri, Mar 24, 2023 at 10:02:15AM +0100, Philippe Mathieu-Daudé wrote:
On 23/3/23 18:36, Andy Shevchenko wrote:quoted
The pci_bus_for_each_resource() can hide the iterator loop since it may be not used otherwise. With this, we may drop that iterator variable definition. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Krzysztof Wilczyński <redacted> --- drivers/eisa/pci_eisa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/eisa/pci_eisa.c b/drivers/eisa/pci_eisa.cSince this is *PCI* EISA, could be squashed into previous patch.
I believe it would be better to have them separated. But if maintainers want to squash, I can do that.
Reviewed-by: Philippe Mathieu-Daudé <redacted>
Thank you! -- With Best Regards, Andy Shevchenko