Re: [PATCH 10/22] mips/cpu: Make sure play_dead() doesn't return

[PATCH 00/22] cpu,sched: Mark arch_cpu_idle_dead() __noreturn · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
[PATCH 01/22] alpha/cpu: Expose arch_cpu_idle_dead()'s prototype declaration · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
[PATCH 03/22] arm/cpu: Make sure arch_cpu_idle_dead() doesn't return · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
[PATCH 02/22] alpha/cpu: Make sure arch_cpu_idle_dead() doesn't return · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
[PATCH 04/22] arm64/cpu: Mark cpu_die() __noreturn · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
[PATCH 05/22] csky/cpu: Make sure arch_cpu_idle_dead() doesn't return · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
Re: [PATCH 05/22] csky/cpu: Make sure arch_cpu_idle_dead() doesn't return · Guo Ren <guoren@kernel.org> · 2023-02-04
Re: [PATCH 05/22] csky/cpu: Make sure arch_cpu_idle_dead() doesn't return · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-04
Re: [PATCH 05/22] csky/cpu: Make sure arch_cpu_idle_dead() doesn't return · Guo Ren <guoren@kernel.org> · 2023-02-06
[PATCH 06/22] ia64/cpu: Mark play_dead() __noreturn · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
[PATCH 08/22] loongarch/cpu: Mark play_dead() __noreturn · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
[PATCH 07/22] loongarch/cpu: Make sure play_dead() doesn't return · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
[PATCH 10/22] mips/cpu: Make sure play_dead() doesn't return · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
Re: [PATCH 10/22] mips/cpu: Make sure play_dead() doesn't return · Florian Fainelli <f.fainelli@gmail.com> · 2023-02-06
[PATCH 09/22] mips/cpu: Expose play_dead()'s prototype definition · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
Re: [PATCH 09/22] mips/cpu: Expose play_dead()'s prototype definition · Florian Fainelli <f.fainelli@gmail.com> · 2023-02-06
[PATCH 11/22] mips/cpu: Mark play_dead() __noreturn · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
Re: [PATCH 11/22] mips/cpu: Mark play_dead() __noreturn · Florian Fainelli <f.fainelli@gmail.com> · 2023-02-06
[PATCH 12/22] powerpc/cpu: Mark start_secondary_resume() __noreturn · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
Re: [PATCH 12/22] powerpc/cpu: Mark start_secondary_resume() __noreturn · Michael Ellerman <mpe@ellerman.id.au> · 2023-02-06
Re: [PATCH 12/22] powerpc/cpu: Mark start_secondary_resume() __noreturn · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-06
[PATCH 13/22] sh/cpu: Make sure play_dead() doesn't return · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
[PATCH 15/22] sh/cpu: Expose arch_cpu_idle_dead()'s prototype definition · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
[PATCH 14/22] sh/cpu: Mark play_dead() __noreturn · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
[PATCH 16/22] sparc/cpu: Mark cpu_play_dead() __noreturn · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
[PATCH 17/22] x86/cpu: Make sure play_dead() doesn't return · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
[PATCH 19/22] xtensa/cpu: Make sure cpu_die() doesn't return · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
[PATCH 20/22] xtensa/cpu: Mark cpu_die() __noreturn · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
[PATCH 21/22] sched/idle: Make sure weak version of arch_cpu_idle_dead() doesn't return · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
[PATCH 18/22] x86/cpu: Mark play_dead() __noreturn · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
[PATCH 22/22] sched/idle: Mark arch_cpu_idle_dead() __noreturn · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-03
[PATCH v1.1 22/22] sched/idle: Mark arch_cpu_idle_dead() __noreturn · Josh Poimboeuf <jpoimboe@kernel.org> · 2023-02-07

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2023-02-06 22:37:13
Also in: linux-alpha, linux-mips, linux-sh, lkml, loongarch, sparclinux

On 2/3/23 14:05, Josh Poimboeuf wrote:

play_dead() doesn't return.  Make that more explicit with a BUG().

BUG() is preferable to unreachable() because BUG() is a more explicit
failure mode and avoids undefined behavior like falling off the edge of
the function into whatever code happens to be next.

Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help