Thread (32 messages) 32 messages, 4 authors, 2023-02-07

Re: [PATCH 12/22] powerpc/cpu: Mark start_secondary_resume() __noreturn

From: Josh Poimboeuf <jpoimboe@kernel.org>
Date: 2023-02-06 22:22:16
Also in: linux-alpha, linux-arm-kernel, linux-mips, linux-sh, lkml, loongarch, sparclinux

On Mon, Feb 06, 2023 at 10:10:22PM +1100, Michael Ellerman wrote:
Josh Poimboeuf [off-list ref] writes:
quoted
start_secondary_resume() doesn't return.  Annotate it as such.  By
extension this also makes arch_cpu_idle_dead() noreturn.
Can we also mark arch_cpu_idle_dead() (the C function) __noreturn ?

Seems like it would be good documentation, even if it's not required
once the generic prototype is __noreturn.
Yeah, agreed.  Maybe I'll do that (for all the implementations) with
patch 22.
But not a show-stopper.

Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
Thanks!

-- 
Josh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help