Thread (29 messages) 29 messages, 9 authors, 2023-03-22

Re: [PATCH v4 4/7] mm: replace vma->vm_flags direct modifications with modifier calls

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2023-01-31 23:12:16
Also in: linux-arm-kernel, linux-mm, lkml

On Tue, 31 Jan 2023 13:08:19 -0800 Suren Baghdasaryan [off-list ref] wrote:
On Tue, Jan 31, 2023 at 12:54 PM Andrew Morton
[off-list ref] wrote:
quoted
On Tue, 31 Jan 2023 10:54:22 -0800 Suren Baghdasaryan [off-list ref] wrote:
quoted
quoted
quoted
-             vma->vm_flags &= ~VM_MAYWRITE;
+             vm_flags_clear(vma, VM_MAYSHARE);
      }
I think it should be:
        s/VM_MAYSHARE/VM_MAYWRITE/
I added the fixup.  Much better than resending a seven patch series for a
single line change.  Unless you have substantial other changes pending.
Thanks! That sounds reasonable.

I'll also need to introduce vm_flags_reset_once() to use in
replacement of WRITE_ONCE(vma->vm_flags, newflags) case. Should I send
a separate short patch for that?
That depends on what the patch looks like.  How about you send it
and we'll see?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help