[PATCH v2 13/33] mm/mmap: move VMA locking before vma_adjust_trans_huge call

[PATCH v2 00/33] Per-VMA locks · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 02/33] maple_tree: Detect dead nodes in mas_start() · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 05/33] maple_tree: Fix write memory barrier of nodes once dead for RCU mode · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 04/33] maple_tree: remove extra smp_wmb() from mas_dead_leaves() · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 06/33] maple_tree: Add smp_rmb() to dead node detection · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 07/33] mm: Enable maple tree RCU mode by default. · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 09/33] mm: rcu safe VMA freeing · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 10/33] mm: move mmap_lock assert function definitions · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 11/33] mm: add per-VMA lock and helper functions to control it · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 12/33] mm: mark VMA as being written when changing vm_flags · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 13/33] mm/mmap: move VMA locking before vma_adjust_trans_huge call · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 14/33] mm/khugepaged: write-lock VMA while collapsing a huge page · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 08/33] mm: introduce CONFIG_PER_VMA_LOCK · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 15/33] mm/mmap: write-lock VMAs before merging, splitting or expanding them · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 19/33] mm: conditionally write-lock VMA in free_pgtables · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 17/33] mm/mremap: write-lock VMA while remapping it to a new address range · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 22/33] mm/mmap: prevent pagefault handler from racing with mmu_notifier registration · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 20/33] mm/mmap: write-lock adjacent VMAs if they can grow into unmapped area · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 21/33] kernel/fork: assert no VMA readers during its destruction · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 23/33] mm: introduce lock_vma_under_rcu to be used from arch-specific code · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 27/33] mm: prevent userfaults to be handled under per-vma lock · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 28/33] mm: introduce per-VMA lock statistics · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 25/33] mm: add FAULT_FLAG_VMA_LOCK flag · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 29/33] x86/mm: try VMA lock-based page fault handling first · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 24/33] mm: fall back to mmap_lock if vma->anon_vma is not yet set · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 16/33] mm/mmap: write-lock VMA before shrinking or expanding it · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 31/33] powerc/mm: try VMA lock-based page fault handling first · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 32/33] mm/mmap: free vm_area_struct without call_rcu in exit_mmap · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 26/33] mm: prevent do_swap_page from handling page faults under VMA lock · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 30/33] arm64/mm: try VMA lock-based page fault handling first · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 33/33] mm: separate vma->lock from vm_area_struct · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 03/33] maple_tree: Fix freeing of nodes in rcu mode · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 18/33] mm: write-lock VMAs before removing them from VMA tree · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
[PATCH v2 01/33] maple_tree: Be more cautious about dead nodes · Suren Baghdasaryan <surenb@google.com> · 2023-01-27
Re: [PATCH v2 00/33] Per-VMA locks · Andrew Morton <akpm@linux-foundation.org> · 2023-01-27
Re: [PATCH v2 00/33] Per-VMA locks · Matthew Wilcox <willy@infradead.org> · 2023-01-27
Re: [PATCH v2 00/33] Per-VMA locks · Suren Baghdasaryan <surenb@google.com> · 2023-01-28
Re: [PATCH v2 00/33] Per-VMA locks · Suren Baghdasaryan <surenb@google.com> · 2023-02-14

STALE1209d

From: Suren Baghdasaryan <surenb@google.com>
Date: 2023-01-27 19:44:09
Also in: linux-arm-kernel, linux-mm, lkml
Subsystem: memory management, memory mapping, the rest · Maintainers: Andrew Morton, Liam R. Howlett, Lorenzo Stoakes, Linus Torvalds

vma_adjust_trans_huge() modifies the VMA and such modifications should
be done after VMA is marked as being written. Therefore move VMA flag
modifications before vma_adjust_trans_huge() so that VMA is marked
before all these modifications.

Signed-off-by: Suren Baghdasaryan <surenb@google.com>
---
 mm/mmap.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/mmap.c b/mm/mmap.c
index 9efe13d36df7..7467d691e357 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c

@@ -2910,11 +2910,12 @@ static int do_brk_flags(struct vma_iterator *vmi, struct vm_area_struct *vma,
 		if (vma_iter_prealloc(vmi))
 			goto unacct_fail;
 
+		/* Set flags first to implicitly lock the VMA before updates */
+		vm_flags_set(vma, VM_SOFTDIRTY);
 		vma_adjust_trans_huge(vma, vma->vm_start, addr + len, 0);
 		init_vma_prep(&vp, vma);
 		vma_prepare(&vp);
 		vma->vm_end = addr + len;
-		vm_flags_set(vma, VM_SOFTDIRTY);
 		vma_iter_store(vmi, vma);
 
 		vma_complete(&vp, vmi, mm);

-- 
2.39.1

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help